Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/minio] helm lint fix #19532

Merged
merged 5 commits into from
Dec 13, 2019
Merged

[stable/minio] helm lint fix #19532

merged 5 commits into from
Dec 13, 2019

Conversation

ahma
Copy link
Contributor

@ahma ahma commented Dec 11, 2019

What this PR does / why we need it:

Fix the helm3 strict lint result.

  • [ERROR] templates/: template: minio/templates/serviceaccount.yaml:5:11: executing "minio/templates/serviceaccount.yaml" at <include "minio.serviceAccountName" .>: error calling include: template: minio/templates/_helpers.tpl:83:13: executing "minio.serviceAccountName" at <include "minio.fullname" .>: error calling include: template: minio/templates/_helpers.tpl:15:14: executing "minio.fullname" at <.Values.fullnameOverride>: map has no entry for key "fullnameOverride"

  • [ERROR] templates/: template: minio/templates/service.yaml:35:14: executing "minio/templates/service.yaml" at <.Values.service.externalIPs>: map has no entry for key "externalIPs"

  • [ERROR] templates/: template: minio/templates/pvc.yaml:2:51: executing "minio/templates/pvc.yaml" at <.Values.persistence.existingClaim>: map has no entry for key "existingClaim"

  • [ERROR] templates/: template: minio/templates/pvc.yaml:24:14: executing "minio/templates/pvc.yaml" at <.Values.persistence.storageClass>: map has no entry for key "storageClass"

  • [ERROR] templates/: template: minio/templates/pvc.yaml:31:14: executing "minio/templates/pvc.yaml" at <.Values.persistence.VolumeName>: map has no entry for key "VolumeName"

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ahma. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 11, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Dec 11, 2019
@ahma
Copy link
Contributor Author

ahma commented Dec 11, 2019

/assign @nitisht

@nitisht
Copy link
Contributor

nitisht commented Dec 11, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2019
@krisis
Copy link
Collaborator

krisis commented Dec 11, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@ahma
Copy link
Contributor Author

ahma commented Dec 12, 2019

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Dec 12, 2019
@ahma
Helm lint fix
6a1a9f3 
Signed-off-by: Ferenc Hernadi <[email protected]>
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2019
@ahma
Copy link
Contributor Author

ahma commented Dec 12, 2019 •
edited
Loading

@davidkarlsen could you please reapprove this

@ahma
Copy link
Contributor Author

ahma commented Dec 13, 2019

@nitisht @krisis Could you put the lgtm label into this ? Thanks

@nitisht
Copy link
Contributor

nitisht commented Dec 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 13, 2019
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Dec 13, 2019
@ahma
Version bump again
94cc73a 
Signed-off-by: Ferenc Hernadi <[email protected]>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Dec 13, 2019
@nitisht
Copy link
Contributor

nitisht commented Dec 13, 2019

/ok-to-test

@ahma
Copy link
Contributor Author

ahma commented Dec 13, 2019

@nitisht thanks for your support, could you please to the label again. I'll try it for last ...

@nitisht
Copy link
Contributor

nitisht commented Dec 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahma, davidkarlsen, krisis, nitisht

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 703d872 into helm:master Dec 13, 2019
@ahma ahma deleted the minio-helm3-lint branch December 13, 2019 10:45
bviolier added a commit to bviolier/charts that referenced this pull request Dec 14, 2019
@bviolier
Merge branch 'master' into add-resources-to-sysctlImage
664611a 
* master: (377 commits)
  [stable/mysql] Update MySQL to the latest 5.7.28 (helm#19561)
  [stable/openebs] Update charts to 1.5.0 release (helm#19587)
  [Velero] Enable prometheus metrics by default (helm#19595)
  [stable/ambassador] Add missing logservices.getambassador.io from the crds (helm#19593)
  [incubator/zookeeper] Fix zookeeper service template (helm#19556)
  [stable/datadog] Add validity checks on clusterName (helm#19327)
  [stable/datadog] Make the seccomp profile for system-probe optional (helm#19533)
  [stable/traefik] Allow custom caServer for ACME and allow string type for acme.staging (helm#19567)
  [stable/wordpress] adds loadBalancerSourceRanges to service (helm#19549)
  [stable/datadog] Add nodeSelector for Cluster Agent Deployment (helm#19430)
  [stable/parse] Configure parse-dashboard to form Urls with HTTPS protocol (helm#19582)
  [stable/traefik] Bump Traefik version and chart version (helm#19524)
  [stable/traefik] fix default value of acme.challengeType for Traefik (helm#19568)
  [stable/minio] helm lint fix  (helm#19532)
  fix external-dns/README.md files table corruption (helm#19581)
  Fixes helm#19111 (helm#19583)
  [stable/wordpress] Release 8.0.2 updating components versions (helm#19579)
  [stable/datadog] add celenechang to datadog owners (helm#19515)
  Anchore Engine Enterprise 2.2 (helm#19575)
  [stable/rabbitmq-ha] Scrape prometheusPlugin metrics without operator (helm#19258)
  ...

# Conflicts:
#	stable/redis-ha/Chart.yaml
mced pushed a commit to mced/charts that referenced this pull request Dec 26, 2019
@ahma @mced
[stable/minio] helm lint fix (helm#19532)
84f5d95 
* Helm lint fix

Signed-off-by: Ferenc Hernadi <[email protected]>

* FAIL: pull-charts-e2e -> version bump (3.0.5 -> 3.0.6)

Signed-off-by: Ferenc Hernadi <[email protected]>

* Version bump again

Signed-off-by: Ferenc Hernadi <[email protected]>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@ahma @dargolith
[stable/minio] helm lint fix (helm#19532)
baa694e 
* Helm lint fix

Signed-off-by: Ferenc Hernadi <[email protected]>

* FAIL: pull-charts-e2e -> version bump (3.0.5 -> 3.0.6)

Signed-off-by: Ferenc Hernadi <[email protected]>

* Version bump again

Signed-off-by: Ferenc Hernadi <[email protected]>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@ahma
[stable/minio] helm lint fix (helm#19532)
169b86d 
* Helm lint fix

Signed-off-by: Ferenc Hernadi <[email protected]>

* FAIL: pull-charts-e2e -> version bump (3.0.5 -> 3.0.6)

Signed-off-by: Ferenc Hernadi <[email protected]>

* Version bump again

Signed-off-by: Ferenc Hernadi <[email protected]>
Signed-off-by: Artur <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitisht nitisht nitisht approved these changes

@krisis krisis Awaiting requested review from krisis

@vsliouniaev vsliouniaev Awaiting requested review from vsliouniaev

Assignees

@nitisht nitisht

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ahma @k8s-ci-robot @nitisht @krisis @davidkarlsen @helm-bot