Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/jenkins] add yamlMergeStrategy to agent default template #22593

Merged
merged 2 commits into from
May 31, 2020
Merged

[stable/jenkins] add yamlMergeStrategy to agent default template #22593

merged 2 commits into from
May 31, 2020

Conversation

ArchiFleKs
Copy link
Contributor

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@k8s-ci-robot k8s-ci-robot requested review from lachie83 and maorfr May 29, 2020 13:46
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 29, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ArchiFleKs. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 29, 2020
@ArchiFleKs
Copy link
Contributor Author

/assign @mogaal

@wmcdona89
Copy link
Collaborator

/assign @wmcdona89

wmcdona89
wmcdona89 suggested changes May 29, 2020
View reviewed changes
Copy link
Collaborator

@wmcdona89 wmcdona89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArchiFleKs thanks for the contribution!

please rebase and add an entry in the CHANGELOG

stable/jenkins/values.yaml Show resolved Hide resolved
stable/jenkins/README.md Outdated Show resolved Hide resolved
@ArchiFleKs ArchiFleKs force-pushed the jenkins/yamloverride branch from 59f0f1f to f7bc126 Compare May 30, 2020 18:25
torstenwalter
torstenwalter reviewed May 31, 2020
View reviewed changes
Copy link
Collaborator

@torstenwalter torstenwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 31, 2020
@torstenwalter
Copy link
Collaborator

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 31, 2020
@torstenwalter
Copy link
Collaborator

@ArchiFleKs Can you add an entry to CHANGELOG.md?

@torstenwalter
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArchiFleKs, torstenwalter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 21ac2db into helm:master May 31, 2020
@torstenwalter torstenwalter mentioned this pull request May 31, 2020
Merged
3 tasks
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@ArchiFleKs
[stable/jenkins] add yamlMergeStrategy to agent default template (hel…
7213358 
…m#22593)

* [stable/jenkins] add yamlMergeStrategy to default agent

Signed-off-by: Kevin Lefevre <[email protected]>

* review helm#1

Signed-off-by: Kevin Lefevre <[email protected]>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@ArchiFleKs @includerandom
[stable/jenkins] add yamlMergeStrategy to agent default template (hel…
9d71292 
…m#22593)

* [stable/jenkins] add yamlMergeStrategy to default agent

Signed-off-by: Kevin Lefevre <[email protected]>

* review helm#1

Signed-off-by: Kevin Lefevre <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@ArchiFleKs @li-adrienloiseau
[stable/jenkins] add yamlMergeStrategy to agent default template (hel…
2853531 
…m#22593)

* [stable/jenkins] add yamlMergeStrategy to default agent

Signed-off-by: Kevin Lefevre <[email protected]>

* review helm#1

Signed-off-by: Kevin Lefevre <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@ArchiFleKs
[stable/jenkins] add yamlMergeStrategy to agent default template (hel…
a00597e 
…m#22593)

* [stable/jenkins] add yamlMergeStrategy to default agent

Signed-off-by: Kevin Lefevre <[email protected]>

* review #1

Signed-off-by: Kevin Lefevre <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
wmcdona89 pushed a commit to wmcdona89/charts that referenced this pull request Aug 30, 2020
@ArchiFleKs
[stable/jenkins] add yamlMergeStrategy to agent default template (hel…
cb4418f 
…m#22593)

* [stable/jenkins] add yamlMergeStrategy to default agent

Signed-off-by: Kevin Lefevre <[email protected]>

* review #1

Signed-off-by: Kevin Lefevre <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@torstenwalter torstenwalter torstenwalter left review comments

@wmcdona89 wmcdona89 wmcdona89 requested changes

@lachie83 lachie83 Awaiting requested review from lachie83

@maorfr maorfr Awaiting requested review from maorfr

Assignees

@mogaal mogaal

@wmcdona89 wmcdona89

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ArchiFleKs @k8s-ci-robot @wmcdona89 @torstenwalter @mogaal @helm-bot