[stable/mysql] The password values in values.yaml should be provided as base64

[komljen]

If the user wants to provide its own passwords they should be base64 encoded in values.yaml file and not kept in clear text.

[k8s-ci-robot]

Hi @komljen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: komljen
We suggest the following additional approver: mgoodness

Assign the PR to them by writing /assign @mgoodness in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[komljen]

cc @viglesiasce

[prydonius]

IMO base64 is not much better than plain text and this will degrade the UX. The fact that tiller stores values in plain text is a separate issue and can be solved by configuring tiller to use a secret store.

[komljen]

I pretty much agree. Autogenerated passwords are better, but the issue is that on helm upgrade the new passwords are generated. Not sure how to work around this...

UPDATE: I created a new pull request to not recreate passwords on helm upgrade #3494

That seems like a better idea and then we could close this one.

[komljen]

Closing this pull request in favor of #3591