Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add support for encrypted connection between zetcd and etcd #4903

Merged
merged 7 commits into from
May 2, 2018
Merged

Add support for encrypted connection between zetcd and etcd #4903

merged 7 commits into from
May 2, 2018

Conversation

qbast
Copy link
Contributor

@qbast qbast commented Apr 11, 2018 •
edited
Loading

What this PR does / why we need it:

It adds support for using zetcd with etcd cluster configured with TLS security.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

It fixes #4898

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2018
@rjkernick
Copy link
Collaborator

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 16, 2018
@rjkernick
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2018
unguiculus
unguiculus suggested changes Apr 18, 2018
View reviewed changes
Copy link
Member

@unguiculus unguiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to values.yaml as well and comment it out.

stable/zetcd/templates/deployment.yaml Outdated
@@ -29,6 +29,20 @@ spec:
{{- else }}
- "-endpoints"
- "{{ .Values.etcd.endpoints }}"
{{- end }}
{{- if .Values.etcd.tls }}
{{- if .Values.etcd.tls.secret }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call it existingSecret to make it explicit that it is not created by the chart. It's also used by other charts.

Do we really need the inner if statements?

@unguiculus
Copy link
Member

/assign

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 23, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbast, rjkernick, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit cd18797 into helm:master May 2, 2018
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
@qbast
Add support for encrypted connection between zetcd and etcd (helm#4903)
60f0180 
* Add support for encrypted connection between zetcd and etcd. Fixes helm#4898

* Remove added empty lines

* Fix problems found by helm lint

* Fix whitespace

* Fixes after review

* Remove trailing namespaces, increment chart version
or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018
@qbast @or1can
Add support for encrypted connection between zetcd and etcd (helm#4903)
e7bef83 
* Add support for encrypted connection between zetcd and etcd. Fixes helm#4898

* Remove added empty lines

* Fix problems found by helm lint

* Fix whitespace

* Fixes after review

* Remove trailing namespaces, increment chart version
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
@qbast
Add support for encrypted connection between zetcd and etcd (helm#4903)
ad5a0f9 
* Add support for encrypted connection between zetcd and etcd. Fixes helm#4898

* Remove added empty lines

* Fix problems found by helm lint

* Fix whitespace

* Fixes after review

* Remove trailing namespaces, increment chart version

Signed-off-by: voron <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unguiculus unguiculus unguiculus approved these changes

Assignees

@unguiculus unguiculus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zetcd: Support TLS connection to etcd
4 participants
@qbast @rjkernick @unguiculus @k8s-ci-robot