Use factored out testing lib #5231

unguiculus · 2018-04-24T17:54:09Z

Updates CI to use refactored testing library.

Fixes #3772
Fixes #3579

unguiculus · 2018-04-26T19:18:12Z

Based on helm/chart-testing#1

unguiculus · 2018-04-26T19:19:18Z

cc @kubernetes/charts-maintainers

gianrubio · 2018-04-30T09:51:04Z

test/helm-test-e2e.sh


-wget -q ${HELM_URL}/${HELM_TARBALL} -P ${WORKSPACE}
-tar xzfv ${WORKSPACE}/${HELM_TARBALL} -C ${WORKSPACE}
+wget -q "$HELM_URL/$HELM_TARBALL" -P "$WORKSPACE"


should this be packaged in the docker image?

This script is for tests of a few whitelisted charts against Kubernetes master. It is not used in regular charts CI. I did not really do anything with that other than making ShellCheck happy. This should probably be tackled in a separate PR.

gianrubio · 2018-04-30T09:52:11Z

.circleci/config.yml

-           command: test/circle/lint.sh
+  build:
+    docker:
+     - image: unguiculus/chart-testing


please pin a docker version

could you also add the source of this docker image in the git repo?

never mind, I found it in the PR

The image will be updated to gcr.io/kubernetes-charts-ci/test-image:v2.0.0 before the PR is merged.

gianrubio · 2018-04-30T09:55:52Z

test/README.md

@@ -27,19 +27,10 @@ The configuration of the Pull Request trigger is [in the config.json](https://gi

 This snippet tells Test Infra to run the [test/e2e.sh](https://github.com/kubernetes/charts/blob/master/test/e2e.sh)
 when testing is triggered on a pull request. The e2e.sh script will use the [Charts test image](https://github.com/kubernetes/charts/blob/master/test/Dockerfile)
-to run the [test/changed.sh](https://github.com/kubernetes/charts/blob/master/test/changed.sh) script. This script
+to run the [chart_test.sh](https://github.com/kubernetes-helm/chart-testing/blob/master/chart_test.sh) script. This script


this chart_test.sh link is broken

The links should work once helm/chart-testing#1 is merged.

unguiculus · 2018-04-30T12:10:15Z

/assign @mattfarina @viglesiasce

timstoop · 2018-05-23T09:51:37Z

I think it still needs helm/chart-testing#1 to be merged before this one can be?

unguiculus · 2018-05-31T12:39:44Z

CircleCI should become green once #5847 is merged.

mattfarina

On the whole this looks good. I still need to look at the charts testing repo.

mattfarina · 2018-05-31T20:29:08Z

test/Dockerfile

@@ -12,45 +12,19 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.

-FROM debian:8.5
+FROM gcr.io/kubernetes-charts-ci/chart-testing:v1.0.0


Where is the source for this FROM? It's under our control which is why I'm curious.

Side note, I'm starting to ponder Quay because of the container image security scanning.

That's the image containing the new factored out testing stuff.

mattfarina

On the whole this looks good. I would like @viglesiasce or @prydonius to give it a thumbs up, too.

mattfarina · 2018-06-05T16:42:14Z

.circleci/config.yml

    jobs:
-      - build
+      - lint-scripts
+      - lint-charts


Note: Since this name is changing from build the required tests for branch will need to change when this goes in.

mattfarina · 2018-06-06T14:38:22Z

/lgtm

k8s-ci-robot · 2018-06-06T14:38:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattfarina, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mattfarina,unguiculus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* [WIP][CI] Use factored out testing lib * Incorporate upstream changes * Update Docker image for CircleCI * Update Docker image * Update Docker image * Align with upstream changes * Remove dummy chart and bump a few charts for testing * Fix Dockerfile * Align with upstream changes * Add summary * Update Chart.yaml * Update Docker images * Remove chart test bumps * Align with upstream changes * Bump some charts for testing * Create v2.0.0 * Remove chart version bumps * Revert repo-sync.sh in favor of helm#5847 * Bump image version * Use latest chart testing image

* [WIP][CI] Use factored out testing lib * Incorporate upstream changes * Update Docker image for CircleCI * Update Docker image * Update Docker image * Align with upstream changes * Remove dummy chart and bump a few charts for testing * Fix Dockerfile * Align with upstream changes * Add summary * Update Chart.yaml * Update Docker images * Remove chart test bumps * Align with upstream changes * Bump some charts for testing * Create v2.0.0 * Remove chart version bumps * Revert repo-sync.sh in favor of helm#5847 * Bump image version * Use latest chart testing image Signed-off-by: voron <[email protected]>

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2018

unguiculus force-pushed the feature/testing branch 11 times, most recently from ef84444 to 518d41a Compare April 24, 2018 19:20

unguiculus changed the title ~~wip~~ [WIP][CI] Use factored out testing lib Apr 24, 2018

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2018

unguiculus force-pushed the feature/testing branch from 518d41a to 6a95baf Compare April 24, 2018 19:44

[WIP][CI] Use factored out testing lib

37c1e0e

unguiculus force-pushed the feature/testing branch from 6a95baf to 37c1e0e Compare April 24, 2018 19:45

Incorporate upstream changes

867adc9

unguiculus mentioned this pull request Apr 26, 2018

Factor out testing code from charts helm/chart-testing#1

Merged

gianrubio reviewed Apr 30, 2018

View reviewed changes

Update Docker image for CircleCI

867c401

k8s-ci-robot assigned mattfarina and viglesiasce Apr 30, 2018

unguiculus added 2 commits May 23, 2018 21:14

Create v2.0.0

b649c81

Merge remote-tracking branch 'upstream/master' into feature/testing

e658f2c

unguiculus force-pushed the feature/testing branch from c9c59d0 to e658f2c Compare May 23, 2018 19:20

Remove chart version bumps

73f0aa5

unguiculus force-pushed the feature/testing branch from ef4402d to 73f0aa5 Compare May 23, 2018 19:25

unguiculus added 2 commits May 29, 2018 20:01

Merge remote-tracking branch 'upstream/master' into feature/testing

0207761

Merge remote-tracking branch 'upstream/master' into feature/testing

312cf46

unguiculus force-pushed the feature/testing branch 4 times, most recently from 46c4bab to 8a41c2d Compare May 31, 2018 10:48

Merge remote-tracking branch 'upstream/master' into feature/testing

7819365

unguiculus force-pushed the feature/testing branch from 8a41c2d to 7819365 Compare May 31, 2018 10:52

Revert repo-sync.sh in favor of helm#5847

9daafe6

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2018

mattfarina reviewed May 31, 2018

View reviewed changes

mattfarina reviewed Jun 5, 2018

View reviewed changes

unguiculus added 3 commits June 6, 2018 12:30

Bump image version

1494062

Use latest chart testing image

dca6ef5

Merge remote-tracking branch 'upstream/master' into feature/testing

2110053

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2018

k8s-ci-robot merged commit cad8ca9 into helm:master Jun 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use factored out testing lib #5231

Use factored out testing lib #5231

unguiculus commented Apr 24, 2018 •

edited

Loading

unguiculus commented Apr 26, 2018

unguiculus commented Apr 26, 2018

gianrubio Apr 30, 2018

unguiculus Apr 30, 2018

gianrubio Apr 30, 2018

gianrubio Apr 30, 2018

gianrubio Apr 30, 2018

unguiculus Apr 30, 2018

gianrubio Apr 30, 2018

unguiculus Apr 30, 2018

unguiculus commented Apr 30, 2018

timstoop commented May 23, 2018

unguiculus commented May 31, 2018

mattfarina left a comment

mattfarina May 31, 2018

unguiculus Jun 1, 2018 •

edited

Loading

mattfarina left a comment

mattfarina Jun 5, 2018

mattfarina commented Jun 6, 2018

k8s-ci-robot commented Jun 6, 2018

Use factored out testing lib #5231

Use factored out testing lib #5231

Conversation

unguiculus commented Apr 24, 2018 • edited Loading

unguiculus commented Apr 26, 2018

unguiculus commented Apr 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unguiculus commented Apr 30, 2018

timstoop commented May 23, 2018

unguiculus commented May 31, 2018

mattfarina left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unguiculus Jun 1, 2018 • edited Loading

Choose a reason for hiding this comment

mattfarina left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattfarina commented Jun 6, 2018

k8s-ci-robot commented Jun 6, 2018

unguiculus commented Apr 24, 2018 •

edited

Loading

unguiculus Jun 1, 2018 •

edited

Loading