-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Conversation
Signed-off-by: Joshua Lambert <[email protected]>
2ee8a09
to
ab7a5a7
Compare
Signed-off-by: Joshua Lambert <[email protected]>
12e0de7
to
24e80df
Compare
/assign @viglesiasce |
Signed-off-by: Joshua Lambert <[email protected]>
/lgtm |
/ok-to-test |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cpanato, lambertjosh If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lambertjosh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cpanato thanks for reviewing, the errors in the deploy are unrelated to this PR as they also occur in the current published version. (Probably a change in the cassandra dependency.) What is the best way to proceed here? Are we blocked from changes until someone fixes whatever issue is going on with cassandra? |
@lambertjosh I will try to check later this week what is happening 😄 |
Actually it looks like there is an existing issue here working on the cassandra problem: #7407 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
Signed-off-by: Francois JACQUES <[email protected]>
…10414) Signed-off-by: Francois JACQUES <[email protected]>
helm#10414) Signed-off-by: Francois JACQUES <[email protected]>
helm#10414) Signed-off-by: Francois JACQUES <[email protected]>
helm#10414) Signed-off-by: Francois JACQUES <[email protected]>
…ts#7490. (#10414) Signed-off-by: Francois JACQUES <[email protected]>
What this PR does / why we need it:
Jaeger has added a new option to set the base path of the query UI, which makes it usable behind reverse proxies. This option should also be exposed in the chart as well.
PR which added this support: jaegertracing/jaeger#748
Docs on set up: https://www.jaegertracing.io/docs/deployment/#ui-base-path
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #7489Special notes for your reviewer: