Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add basePath option for Jaeger #7490

Closed
wants to merge 3 commits into from

Conversation

lambertjosh
Copy link
Contributor

@lambertjosh lambertjosh commented Sep 2, 2018

What this PR does / why we need it:

Jaeger has added a new option to set the base path of the query UI, which makes it usable behind reverse proxies. This option should also be exposed in the chart as well.

PR which added this support: jaegertracing/jaeger#748
Docs on set up: https://www.jaegertracing.io/docs/deployment/#ui-base-path

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #7489

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2018
Signed-off-by: Joshua Lambert <[email protected]>
@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 2, 2018
Signed-off-by: Joshua Lambert <[email protected]>
@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 2, 2018
@lambertjosh
Copy link
Contributor Author

/assign @viglesiasce

@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 3, 2018
@cpanato
Copy link
Member

cpanato commented Sep 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2018
@cpanato
Copy link
Member

cpanato commented Sep 3, 2018

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato, lambertjosh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: viglesiasce

If they are not already assigned, you can assign the PR to them by writing /assign @viglesiasce in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2018
@k8s-ci-robot
Copy link
Contributor

@lambertjosh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e a1bbdde link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lambertjosh
Copy link
Contributor Author

@cpanato thanks for reviewing, the errors in the deploy are unrelated to this PR as they also occur in the current published version. (Probably a change in the cassandra dependency.)

What is the best way to proceed here? Are we blocked from changes until someone fixes whatever issue is going on with cassandra?

@cpanato
Copy link
Member

cpanato commented Sep 4, 2018

@lambertjosh I will try to check later this week what is happening 😄

@lambertjosh
Copy link
Contributor Author

Actually it looks like there is an existing issue here working on the cassandra problem: #7407

@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2018
@stale
Copy link

stale bot commented Oct 18, 2018

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Oct 18, 2018
hypnoce added a commit to hypnoce/charts that referenced this pull request Jan 5, 2019
k8s-ci-robot pushed a commit that referenced this pull request Jan 7, 2019
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
scottrigby pushed a commit to jaegertracing/helm-charts that referenced this pull request Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[incubator/jaeger] Add option for specifying basePath
5 participants