This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/kuberos] add support for custom annotations in service #7964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ey-bot
added
the
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
cpanato
reviewed
Sep 27, 2018
| @@ -62,6 +62,8 @@ image: | |||
| service: | |||
| type: ClusterIP | |||
| port: 80 | |||
| annotations: {} | |||
There was a problem hiding this comment.
can you add this in the readme as well?
There was a problem hiding this comment.
Done, I also added entries to the existing service fields.
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
Signed-off-by: Cezar Sa Espinola <[email protected]>
|
/lgtm |
helm-bot
added
the
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarsa, cpanato, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pmontanari
pushed a commit
to pmontanari/charts
that referenced
this pull request
Nov 2, 2018
…7964) Signed-off-by: Cezar Sa Espinola <[email protected]> Signed-off-by: Patrick Montanari <[email protected]>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
…7964) Signed-off-by: Cezar Sa Espinola <[email protected]> Signed-off-by: Jakob Niggel <[email protected]>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
…7964) Signed-off-by: Cezar Sa Espinola <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds optional annotations to the service created by the stable/kuberos chart.
Special notes for your reviewer:
cc @timothyclarke
Checklist