This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Move liveness and readiness probe to values.yaml #7982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
needs-ok-to-test
Signed-off-by: Shubham Jain <[email protected]>
Signed-off-by: Shubham Jain <[email protected]>
slayerjain
force-pushed
the
move-liveness-readiness
branch
from
f4c70a5 to
422d7f9
Compare
ey-bot
added
Contribution Allowed
Signed-off-by: Shubham Jain <[email protected]>
slayerjain
force-pushed
the
move-liveness-readiness
branch
from
038bcf7 to
eba1cf6
Compare
ey-bot
added
the
Contribution Allowed
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
|
/assign @seanknox |
Signed-off-by: Reinhard Nägele <[email protected]>
helm-bot
added
the
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, slayerjain, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pmontanari
pushed a commit
to pmontanari/charts
that referenced
this pull request
Nov 2, 2018
* move readiness and liveness probe details to value.yaml Signed-off-by: Shubham Jain <[email protected]> * chart version bumped Signed-off-by: Shubham Jain <[email protected]> * Remove trailing spaces Signed-off-by: Shubham Jain <[email protected]> * Update Chart.yaml Signed-off-by: Reinhard Nägele <[email protected]> Signed-off-by: Patrick Montanari <[email protected]>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* move readiness and liveness probe details to value.yaml Signed-off-by: Shubham Jain <[email protected]> * chart version bumped Signed-off-by: Shubham Jain <[email protected]> * Remove trailing spaces Signed-off-by: Shubham Jain <[email protected]> * Update Chart.yaml Signed-off-by: Reinhard Nägele <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It moves the readiness and liveness probe to values.yaml so that they're configurable.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)- fixes #
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]