Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/aerospike] Fix typo in README wit->wait #9622

Merged
merged 4 commits into from
Dec 17, 2018

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Nov 29, 2018

What this PR does / why we need it:

  • Fix typo wit->wait
  • Make capitalisation of configuration table consistent

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

* Fix typo wit->wait
* Make capitalisation of configuration table consistent

Signed-off-by: Dean Coakley <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2018
Signed-off-by: Dean Coakley <[email protected]>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2018
@Dean-Coakley Dean-Coakley deleted the patch-1 branch November 30, 2018 01:35
@Dean-Coakley Dean-Coakley restored the patch-1 branch November 30, 2018 01:35
@Dean-Coakley Dean-Coakley reopened this Nov 30, 2018
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2018
@Dean-Coakley
Copy link
Contributor Author

@paulczar @mgoodness Can I get a review on this?

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2018
Signed-off-by: Paul Czarkowski <[email protected]>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2018
@paulczar
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dean-Coakley, paulczar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit def1b8f into helm:master Dec 17, 2018
@Dean-Coakley Dean-Coakley deleted the patch-1 branch December 18, 2018 02:27
coreypobrien pushed a commit to FairwindsOps/helm-charts that referenced this pull request Dec 31, 2018
* [stable/aerospike] Fix typo in README wit->wait

* Fix typo wit->wait
* Make capitalisation of configuration table consistent

Signed-off-by: Dean Coakley <[email protected]>

* Increment chart version

Signed-off-by: Dean Coakley <[email protected]>

* fix version bump

Signed-off-by: Paul Czarkowski <[email protected]>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
* [stable/aerospike] Fix typo in README wit->wait

* Fix typo wit->wait
* Make capitalisation of configuration table consistent

Signed-off-by: Dean Coakley <[email protected]>

* Increment chart version

Signed-off-by: Dean Coakley <[email protected]>

* fix version bump

Signed-off-by: Paul Czarkowski <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants