Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add corresponding unit test to the function in resource.go. #7290

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Add corresponding unit test to the function in resource.go. #7290

merged 1 commit into from
Dec 23, 2019

Conversation

fenggw-fnst
Copy link
Contributor

Signed-off-by: Guangwen Feng [email protected]

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 23, 2019
thomastaylor312
thomastaylor312 approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition here!

@thomastaylor312 thomastaylor312 added this to the 3.1.0 milestone Dec 23, 2019
@thomastaylor312 thomastaylor312 merged commit 1ff8272 into helm:master Dec 23, 2019
@fenggw-fnst fenggw-fnst deleted the work branch December 24, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

Assignees
No one assigned
Labels
feature size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fenggw-fnst @thomastaylor312 @helm-bot