Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port latest release branch updates to main #1335

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jan 31, 2024

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Support for PyTorch 2.1.x & various changes on the CI.

Issue/s resolved: #

Changes proposed:

for more information, see https://pre-commit.ci

  • skip sparse test mul

  • read envar for skipping

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

* Support latest PyTorch release

* add checklist to PR description

* add pytorch 2.0 to list

* Support latest PyTorch release (#1311)

Co-authored-by: mtar <[email protected]>

* activate carry forward flag

* start pr test only on path heat/**

* update test environment settings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* skip sparse test mul

* read envar for skipping

---------

Co-authored-by: ClaudiaComito <[email protected]>
Co-authored-by: Claudia Comito <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mtar <[email protected]>
Co-authored-by: Michael Tarnawa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@mtar mtar marked this pull request as ready for review January 31, 2024 13:06
@mtar mtar requested a review from ClaudiaComito January 31, 2024 13:06
@ghost
Copy link

ghost commented Jan 31, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@mtar mtar changed the title latest release updates to main port latest release branch updates to main Jan 31, 2024
@mtar mtar added testing Implementation of tests, or test-related issues workflows labels Jan 31, 2024
@mtar mtar requested a review from mrfh92 January 31, 2024 13:44
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine :)
Thanks 👍

@mtar mtar merged commit 394fc38 into main Jan 31, 2024
48 checks passed
@mtar mtar deleted the enhancement/release-bug-update branch January 31, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Implementation of tests, or test-related issues workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants