Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters will no longer format tutorials #1748

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Dec 12, 2024

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested Does Not Apply
    • unit tests: multiple dtypes tested Does Not Apply
    • benchmarks: created for new functionality Does Not Apply
    • benchmarks: performance improved or maintained Does Not Apply
    • documentation updated where needed Does Not Apply

Description

Modifying pre-commit-config to prevent picky formatting of our tutorials. Once this is merged, we can address formatting in #1523

Issue/s resolved: None

Changes proposed:

Type of change

NA

Memory requirements

NA

Performance

NA

Does this change modify the behaviour of other functions? If so, which?

no

Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks fine; copilot agrees.

@ClaudiaComito ClaudiaComito merged commit 8e8c37d into main Dec 13, 2024
46 checks passed
@ClaudiaComito ClaudiaComito deleted the workflows/no_black_for_tutorials branch December 13, 2024 13:01
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
Copy link
Contributor

Successfully created backport PR for release/1.5.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants