-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix binary_op on operands with single element #868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
=======================================
Coverage 95.48% 95.49%
=======================================
Files 64 64
Lines 9463 9472 +9
=======================================
+ Hits 9036 9045 +9
Misses 427 427
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
coquelin77
reviewed
Sep 23, 2021
coquelin77
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a known bug in _operations.__binary_op() where the data of an DNDarray is copied to all processors if it only contains one element.
The fix introduces the method 'Split()' to MPICommunicator for splitting it into new ones. These new ones are used for the data transfer in __binary_op()
Issue/s resolved: #866
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no