Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conversations): Added "missing" functionality to get truncated threads #317

Conversation

wotta
Copy link
Contributor

@wotta wotta commented May 20, 2024

According to the following documentation there is an option to get truncated threads from the conversation API.
See the documentation here: https://developer.helpscout.com/mailbox-api/endpoints/conversations/list/

Note: If using the embed=threads parameter with this call, you will see truncated chat threads. This is by design. To view Beacon chat threads in full, call the [List Threads](https://developer.helpscout.com/mailbox-api/endpoints/conversations/threads/list/) endpoint for that conversation instead.

I updated the ConversationFilters to allow using the embed=threads logic in order to minimize the time it takes for the API to return a response. When I use the new (ConversationReques())->withThreads() the api really takes a toll before a response is actually given.

@wotta wotta marked this pull request as draft May 20, 2024 09:56
@wotta wotta marked this pull request as ready for review May 20, 2024 11:45
@miguelrs miguelrs merged commit 80d7c9a into helpscout:master Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants