Skip to content

Commit

Permalink
Did not strip latest tag with previous step, changing this
Browse files Browse the repository at this point in the history
  • Loading branch information
joshua-seals committed Oct 23, 2024
1 parent a5b2b27 commit b76a42b
Showing 1 changed file with 23 additions and 5 deletions.
28 changes: 23 additions & 5 deletions .github/workflows/helx-build-test-upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ jobs:
password: ${{ secrets.CONTAINERHUB_TOKEN }}
logout: true

- name: Docker meta
- name: Docker meta Prod
if: ${{ github.ref != 'refs/heads/main' }}
id: meta
uses: docker/metadata-action@v5
with:
Expand All @@ -106,6 +107,23 @@ jobs:
type=raw,value=cuda
type=raw,value=latest
- name: Docker meta Dev
if: ${{ github.ref != 'refs/heads/develop' }}
id: meta
uses: docker/metadata-action@v5
with:
# list of Docker images to use as base name for tags
images: |
${{ env.OWNER }}/${{ inputs.image }}
containers.renci.org/${{ env.OWNER }}/jupyter/docker-stacks/${{ inputs.image }}
# generate Docker tags based on the following events/attributes
# using the type=raw,value="" syntax allows for custom tags.
tags: |
type=ref,event=branch
type=sha
type=raw,value=cuda
- name: Create Temp Dir
run: |
mkdir -p /tmp/jupyter/images/
Expand Down Expand Up @@ -138,10 +156,10 @@ jobs:
# the images being built are in the main branch.
# the 'Run tests' step however expects "latest" tag;
# hence - we just delete the tag after the image is tested.
- name: Remove latest tag if Develop Branch
if: ${{ github.ref != 'refs/heads/main' }}
run: |
docker rmi ${{ env.OWNER }}/${{ inputs.image }}:latest
# - name: Remove latest tag if Develop Branch
# if: ${{ github.ref != 'refs/heads/main' }}
# run: |
# docker rmi ${{ env.OWNER }}/${{ inputs.image }}:latest

- name: Upload artifact 📤
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit b76a42b

Please sign in to comment.