[v2] Improve verification tests for source generators

- Use shorter filenames - Use subdirectories
henrikfroehling · Aug 5, 2024 · 4147661 · 4147661
1 parent 18ad963
commit 4147661
Show file tree

Hide file tree

Showing 207 changed files with 482 additions and 231 deletions.
diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props
@@ -31,6 +31,7 @@
   <!-- Tests Source Generators Dependencies -->
   <ItemGroup>
     <PackageVersion Include="Basic.Reference.Assemblies" Version="1.7.2" />
+    <PackageVersion Include="Verify.DiffPlex" Version="3.1.0" />
     <PackageVersion Include="Verify.SourceGenerators" Version="2.3.0" />
     <PackageVersion Include="Verify.Xunit" Version="26.1.6" />
   </ItemGroup>

diff --git a/.../tools/sourcegeneration/Trakt.NET.SourceGeneration.Tests/Enums/TraktEnumGeneratorTests.cs b/.../tools/sourcegeneration/Trakt.NET.SourceGeneration.Tests/Enums/TraktEnumGeneratorTests.cs
@@ -20,8 +20,8 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumTests", source, customFilename: nameof(TestGeneratesEnumExtensions));
         }
 
         [Fact]
@@ -46,8 +46,8 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberTests", source, customFilename: nameof(TestGeneratesEnumExtensionsWithCustomEnumMember));
         }
 
         [Fact]
@@ -71,8 +71,8 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EmptyEnumMemberTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EmptyEnumMemberTests", source, customFilename: nameof(TestGeneratesEnumExtensionsWithEmptyCustomEnumMember));
         }
 
         [Fact]
@@ -97,8 +97,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberEmptyJsonValueTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberEmptyJsonValueTests", source,
+                customFilename: nameof(TestGeneratesEnumExtensionsWithCustomEnumMemberEmptyJsonValue));
         }
 
         [Fact]
@@ -123,8 +124,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberEmptyDisplayNameTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberEmptyDisplayNameTests", source,
+                customFilename: nameof(TestGeneratesEnumExtensionsWithCustomEnumMemberEmptyDisplayName));
         }
 
         [Fact]
@@ -149,8 +151,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberNullJsonValueDiagnosticsTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberNullJsonValueDiagnosticsTests", source,
+                customFilename: nameof(TestGeneratesEnumExtensionsWithCustomEnumMemberNullJsonValueDiagnostics));
         }
 
         [Fact]
@@ -175,8 +178,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberNullDisplayNameDiagnosticsTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberNullDisplayNameDiagnosticsTests", source,
+                customFilename: nameof(TestGeneratesEnumExtensionsWithCustomEnumMemberNullDisplayNameDiagnostics));
         }
 
         [Fact]
@@ -200,8 +204,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberPathQueryEnumMemberTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberPathQueryEnumMemberTests", source,
+                customFilename: nameof(TestGeneratesEnumExtensionsWithPathAndQueryAndCustomEnumMember));
         }
 
         [Fact]
@@ -226,8 +231,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberPathQueryEnumMemberURITests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberPathQueryEnumMemberURITests", source,
+                customFilename: nameof(TestGeneratesEnumExtensionsWithPathAndQueryAndCustomEnumMemberURI));
         }
 
         [Fact]
@@ -253,8 +259,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberPathQueryEnumMemberFlagsTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberPathQueryEnumMemberFlagsTests", source,
+                customFilename: nameof(TestGeneratesEnumExtensionsWithPathAndQueryAndCustomEnumMemberAndFlagsAttribute));
         }
 
         [Fact]
@@ -281,8 +288,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.EnumMemberPathQueryEnumMemberURIFlagsTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/Enum",
+                "SourceGeneration.EnumMemberPathQueryEnumMemberURIFlagsTests", source,
+                customFilename: nameof(TestGeneratesEnumExtensionsWithPathAndQueryAndCustomEnumMemberURIAndFlagsAttribute));
         }
     }
 }
diff --git a/...generation/Trakt.NET.SourceGeneration.Tests/Enums/TraktPathParameterEnumGeneratorTests.cs b/...generation/Trakt.NET.SourceGeneration.Tests/Enums/TraktPathParameterEnumGeneratorTests.cs
@@ -20,8 +20,8 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.PathParameterEnumTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/ParameterEnum",
+                "SourceGeneration.PathParameterEnumTests", source, customFilename: nameof(TestGeneratesPathParameterEnumExtensions));
         }
 
         [Fact]
@@ -44,8 +44,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.PathParameterFlagsEnumTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/ParameterEnum",
+                "SourceGeneration.PathParameterFlagsEnumTests", source,
+                customFilename: nameof(TestGeneratesPathParameterEnumExtensionsWithFlagsAttribute));
         }
 
         [Fact]
@@ -70,8 +71,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.PathParameterEnumMemberTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/ParameterEnum",
+                "SourceGeneration.PathParameterEnumMemberTests", source,
+                customFilename: nameof(TestGeneratesPathParameterEnumExtensionsWithCustomEnumMember));
         }
 
         [Fact]
@@ -96,8 +98,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.PathParameterEnumMemberURITests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/ParameterEnum",
+                "SourceGeneration.PathParameterEnumMemberURITests", source,
+                customFilename: nameof(TestGeneratesPathParameterEnumExtensionsWithCustomEnumMemberURI));
         }
 
         [Fact]
@@ -124,8 +127,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.PathParameterEnumMemberURIAndFlagsTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/ParameterEnum",
+                "SourceGeneration.PathParameterEnumMemberURIAndFlagsTests", source,
+                customFilename: nameof(TestGeneratesPathParameterEnumExtensionsWithCustomEnumMemberURIAndFlagsAttribute));
         }
 
         [Fact]
@@ -146,8 +150,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.PathParameterQueryEnumTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/ParameterEnum",
+                "SourceGeneration.PathParameterQueryEnumTests", source,
+                customFilename: nameof(TestGeneratesPathParameterEnumExtensionsWithQuerySupport));
         }
 
         [Fact]
@@ -170,8 +175,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.PathParameterQueryFlagsEnumTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/ParameterEnum",
+                "SourceGeneration.PathParameterQueryFlagsEnumTests", source,
+                customFilename: nameof(TestGeneratesPathParameterEnumExtensionsWithQuerySupportAndFlagsAttribute));
         }
     }
 }
diff --git a/...s/sourcegeneration/Trakt.NET.SourceGeneration.Tests/Enums/TraktQueryEnumGeneratorTests.cs b/...s/sourcegeneration/Trakt.NET.SourceGeneration.Tests/Enums/TraktQueryEnumGeneratorTests.cs
@@ -20,8 +20,8 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumTests", source, customFilename: nameof(TestGeneratesQueryEnumExtensions));
         }
 
         [Fact]
@@ -44,8 +44,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumFlagsTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumFlagsTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithFlagsAttribute));
         }
 
         [Fact]
@@ -70,8 +71,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumMemberTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumMemberTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithCustomEnumMember));
         }
 
         [Fact]
@@ -98,8 +100,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumMemberURIAndFlagsTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumMemberURIAndFlagsTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithCustomEnumMemberURIAndFlagsAttribute));
         }
 
         [Fact]
@@ -124,8 +127,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumMemberURITests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumMemberURITests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithCustomEnumMemberURI));
         }
 
         [Fact]
@@ -152,8 +156,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumMemberFlagsTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumMemberFlagsTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithCustomEnumMemberAndFlagsAttribute));
         }
 
         [Fact]
@@ -174,8 +179,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumNullQueryDiagnosticTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumNullQueryDiagnosticTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsEmptyQueryDiagnostics));
         }
 
         [Fact]
@@ -196,8 +202,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumNullQueryDiagnosticTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumNullQueryDiagnosticTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsEmptyQueryWithSupportFlagDiagnostics));
         }
 
         [Fact]
@@ -218,8 +225,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumNullQueryDiagnosticTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumNullQueryDiagnosticTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsNullQueryDiagnostics));
         }
 
         [Fact]
@@ -244,8 +252,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumMemberEmptyJsonValueTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumMemberEmptyJsonValueTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithCustomEnumMemberEmptyJsonValue));
         }
 
         [Fact]
@@ -270,8 +279,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumMemberEmptyDisplayNameTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumMemberEmptyDisplayNameTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithCustomEnumMemberEmptyDisplayName));
         }
 
         [Fact]
@@ -296,8 +306,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumMemberNullJsonValueTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumMemberNullJsonValueTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithCustomEnumMemberNullJsonValue));
         }
 
         [Fact]
@@ -322,8 +333,9 @@ public enum TestEnum
                 }
                 """;
 
-            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums",
-                "SourceGeneration.QueryEnumMemberNullDisplayNameTests", source);
+            return TestHelper.Verify<TraktEnumSourceGenerator>("Enums/QueryEnum",
+                "SourceGeneration.QueryEnumMemberNullDisplayNameTests", source,
+                customFilename: nameof(TestGeneratesQueryEnumExtensionsWithCustomEnumMemberNullDisplayName));
         }
     }
 }