[v2] Fix source generator to properly split enum member names

henrikfroehling · Mar 18, 2024 · 6c57928 · 6c57928
1 parent 2af8612
commit 6c57928
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 10 deletions.
diff --git a/src/libs/Trakt.NET/Enums/TraktAccessTokenType.cs b/src/libs/Trakt.NET/Enums/TraktAccessTokenType.cs
@@ -4,7 +4,7 @@
 namespace TraktNET
 {
     [TraktEnum]
-    [JsonConverter(typeof(TraktAccessScopeJsonConverter))]
+    [JsonConverter(typeof(TraktAccessTokenTypeJsonConverter))]
     public enum TraktAccessTokenType
     {
         Unspecified,

diff --git a/src/libs/Trakt.NET/Enums/TraktEpisodeType.cs b/src/libs/Trakt.NET/Enums/TraktEpisodeType.cs
@@ -0,0 +1,19 @@
+using System.Text.Json.Serialization;
+using TraktNET.SourceGenerators;
+
+namespace TraktNET
+{
+    [TraktEnum]
+    [JsonConverter(typeof(TraktEpisodeTypeJsonConverter))]
+    public enum TraktEpisodeType
+    {
+        Unspecified,
+        Standard,
+        SeriesPremiere,
+        SeasonPremiere,
+        MidSeasonFinale,
+        MidSeasonPremiere,
+        SeasonFinale,
+        SeriesFinale
+    }
+}
diff --git a/src/tools/Trakt.NET.SourceGenerators/SourceGenerationHelper.cs b/src/tools/Trakt.NET.SourceGenerators/SourceGenerationHelper.cs
@@ -1,5 +1,6 @@
-using System.Globalization;
+using System.Globalization;
 using System.Text;
+using System.Text.RegularExpressions;
 
 namespace TraktNET.SourceGenerators
 {
@@ -45,7 +46,7 @@ public static partial class ").Append(enumToGenerate.EnumExtensionClassName);
                 {
                     stringBuilder.Append(@"
                 ").Append(enumToGenerate.Name).Append('.').Append(member)
-                    .Append(" => ").Append('"').Append(member.ToLower(CultureInfo.InvariantCulture)).Append(@""",");
+                    .Append(" => ").Append('"').Append(member.ToLowercaseNamingConvention()).Append(@""",");
                 }
             }
 
@@ -68,13 +69,10 @@ public static partial class ").Append(enumToGenerate.EnumExtensionClassName);
             foreach (string member in enumToGenerate.Values)
             {
                 stringBuilder.Append(@"
-                ").Append($"\"{member.ToLower(CultureInfo.InvariantCulture)}\" => {enumToGenerate.Name}.{member},");
+                ").Append($"\"{member.ToLowercaseNamingConvention()}\" => {enumToGenerate.Name}.{member},");
 
                 stringBuilder.Append(@"
-                ").Append($"\"{member.ToUpper(CultureInfo.InvariantCulture)}\" => {enumToGenerate.Name}.{member},");
-
-                stringBuilder.Append(@"
-                ").Append($"\"{member}\" => {enumToGenerate.Name}.{member},");
+                ").Append($"\"{member.ToLowercaseNamingConvention().ToUpperInvariant()}\" => {enumToGenerate.Name}.{member},");
             }
 
             stringBuilder.Append(@"
@@ -96,7 +94,7 @@ public static partial class ").Append(enumToGenerate.EnumExtensionClassName);
             foreach (string member in enumToGenerate.Values)
             {
                 stringBuilder.Append(@"
-                ").Append(enumToGenerate.Name).Append('.').Append(member).Append(" => ").Append('"').Append(member).Append(@""",");
+                ").Append(enumToGenerate.Name).Append('.').Append(member).Append(" => ").Append('"').Append(member.ToDisplayName()).Append(@""",");
             }
 
             stringBuilder.Append(@"
@@ -107,7 +105,6 @@ public static partial class ").Append(enumToGenerate.EnumExtensionClassName);
 
             stringBuilder.Append(@"
     }
-
 ");
 
             stringBuilder.Append(@"
@@ -140,5 +137,12 @@ public override void Write(Utf8JsonWriter writer, ").Append(enumToGenerate.Name)
 
             return stringBuilder.ToString();
         }
+
+        internal static string ToLowercaseNamingConvention(this string value) => CapitalLetter.Replace(value, "_").ToLowerInvariant();
+
+        internal static string ToDisplayName(this string value) => CapitalLetter.Replace(value, " ");
+
+        private static readonly Regex CapitalLetter = new(@"(?<=[A-Z])(?=[A-Z][a-z]) | (?<=[^A-Z])(?=[A-Z]) | (?<=[A-Za-z])(?=[^A-Za-z])",
+                                                          RegexOptions.IgnorePatternWhitespace);
     }
 }