Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify page navigation #157

Closed
henrikfroehling opened this issue Jul 25, 2020 · 0 comments · Fixed by #455
Closed

Simplify page navigation #157

henrikfroehling opened this issue Jul 25, 2020 · 0 comments · Fixed by #455

Comments

@henrikfroehling
Copy link
Owner

henrikfroehling commented Jul 25, 2020

As seen in #156 the current workflow for page navigation looks like this:

var pagedParameters = new TraktPagedParameters(1, 10); // page = 1, items per page = 10
TraktPagedResponse<ITraktTrendingShow> trendingShowsResponse = await client.Shows.GetTrendingShowsAsync(null, pagedParameters);

// getting the next page
pagedParameters.Page = pagedParameters.Page + 1;
trendingShowsResponse = await client.Shows.GetTrendingShowsAsync(extendedInfo, pagedParameters);

It would be nice to simply call something like this to get the next page:

while (trendingShowsResponse.HasNextPage)
{
    trendingShowsResponse = await trendingShowsResponse.GetNextPageAsync();
}
@henrikfroehling henrikfroehling self-assigned this Jul 25, 2020
@henrikfroehling henrikfroehling added this to the Version 2.0.0 milestone Jan 8, 2022
@henrikfroehling henrikfroehling removed their assignment Jan 8, 2022
@henrikfroehling henrikfroehling moved this to Todo in Trakt.NET Jan 17, 2022
@henrikfroehling henrikfroehling self-assigned this May 1, 2023
@henrikfroehling henrikfroehling linked a pull request May 5, 2023 that will close this issue
henrikfroehling added a commit that referenced this issue May 7, 2023
@github-project-automation github-project-automation bot moved this from Open to Closed in Trakt.NET May 7, 2023
@henrikfroehling henrikfroehling moved this from Closed to Done in Trakt.NET May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant