Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename users/{id}/recommendations/{type}/{sort} request to users/{id}/favorites/{type}/{sort} #555

Closed
Tracked by #577
henrikfroehling opened this issue Jul 12, 2023 · 0 comments · Fixed by #582
Closed
Tracked by #577

Rename users/{id}/recommendations/{type}/{sort} request to users/{id}/favorites/{type}/{sort} #555

henrikfroehling opened this issue Jul 12, 2023 · 0 comments · Fixed by #582
Assignees
@henrikfroehling
Labels
Improvement Library Module Users Target-Branch: release-1.4.0 Trakt API v1.4.0
Milestone
Version 1.4.0

Comments

@henrikfroehling
Copy link
Owner

henrikfroehling commented Jul 12, 2023 •
edited
Loading

API Reference

  • rename URLs
  • rename ITraktRecommendation => ITraktFavorite
  • rename UserPersonalRecommendationsRequest => UserFavoritesRequest
  • rename TraktRecommendationObjectType => TraktFavoriteObjectType
@henrikfroehling henrikfroehling added this to the Version 1.4.0 milestone Jul 12, 2023
@henrikfroehling henrikfroehling moved this from New to Open in Trakt.NET Jul 12, 2023
@henrikfroehling henrikfroehling mentioned this issue Jul 15, 2023
Closed
49 tasks
@henrikfroehling henrikfroehling changed the title Remove TraktUsersModule.GetPersonalRecommendationsAsync() - API endpoint was removed Rename users/{id}/recommendations/{type}/{sort} requests to users/{id}/favorites/{type}/{sort} Jul 21, 2023
@henrikfroehling henrikfroehling self-assigned this Jul 21, 2023
@henrikfroehling henrikfroehling changed the title Rename users/{id}/recommendations/{type}/{sort} requests to users/{id}/favorites/{type}/{sort} Rename users/{id}/recommendations/{type}/{sort} request to users/{id}/favorites/{type}/{sort} Jul 21, 2023
henrikfroehling added a commit that referenced this issue Jul 21, 2023
@henrikfroehling
GH-555: Rename users/{id}/recommendations/{type}/{sort} request to …
b62bbe9 
…`users/{id}/favorites/{type}/{sort}`

- rename URLs
- rename `ITraktRecommendation` => `ITraktFavorite`
- rename `UserPersonalRecommendationsRequest` => `UserFavoritesRequest`
- rename `TraktRecommendationObjectType` => `TraktFavoriteObjectType`
@henrikfroehling henrikfroehling linked a pull request Jul 21, 2023 that will close this issue
PR: #555 - Rename users/{id}/recommendations/{type}/{sort} request to users/{id}/favorites/{type}/{sort} #582
Merged
henrikfroehling added a commit that referenced this issue Jul 21, 2023
@henrikfroehling
Merge pull request #582 from henrikfroehling/issue/release-1.4.0/GH-555
e36b1b9 
Resolves GH-555
@github-project-automation github-project-automation bot moved this from Open to Closed in Trakt.NET Jul 21, 2023
@henrikfroehling henrikfroehling moved this from Closed to Done in Trakt.NET Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrikfroehling henrikfroehling

Labels
Improvement Library Module Users Target-Branch: release-1.4.0 Trakt API v1.4.0
Projects
Trakt.NET
Status: Done
Milestone
Version 1.4.0
1 participant
@henrikfroehling