Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sync/recommendations requests to sync/favorites #556

Closed
Tracked by #576
henrikfroehling opened this issue Jul 12, 2023 · 0 comments · Fixed by #583
Closed
Tracked by #576

Rename sync/recommendations requests to sync/favorites #556

henrikfroehling opened this issue Jul 12, 2023 · 0 comments · Fixed by #583
Assignees
@henrikfroehling
Labels
Improvement Library Module Sync Target-Branch: release-1.4.0 Trakt API v1.4.0
Milestone
Version 1.4.0

Comments

@henrikfroehling
Copy link
Owner

Get favorites => TraktSyncModule.GetPersonalRecommendationsAsync()
Reorder favorited items => TraktSyncModule.ReorderRecommendedItemsAsync()
Add to favorites => TraktSyncModule.AddPersonalRecommendationsAsync()
Remove items from favorites => TraktSyncModule.RemovePersonalRecommendationsAsync()

  • rename URLs
  • rename ITraktRecommendation => ITraktFavorite
  • rename ITraktSyncRecommendationsPost => ITraktSyncFavoritesPost
  • rename ITraktSyncRecommendationsRemovePost => ITraktSyncFavoritesRemovePost
  • rename ITraktSyncRecommendationsPostResponse => ITraktSyncFavoritesPostResponse
  • rename ITraktSyncRecommendationsRemovePostResponse => ITraktSyncFavoritesRemovePostResponse
  • rename ITraktSyncRecommendationsPostBuilder => ITraktSyncFavoritesPostBuilder
  • rename ITraktSyncRecommendationsRemovePostBuilder => ITraktSyncFavoritesRemovePostBuilder
@henrikfroehling henrikfroehling added this to the Version 1.4.0 milestone Jul 12, 2023
@henrikfroehling henrikfroehling self-assigned this Jul 12, 2023
@henrikfroehling henrikfroehling moved this from New to Open in Trakt.NET Jul 12, 2023
@henrikfroehling henrikfroehling mentioned this issue Jul 15, 2023
Closed
32 tasks
henrikfroehling added a commit that referenced this issue Jul 22, 2023
@henrikfroehling
GH-556: Rename sync/recommendations requests to sync/favorites
e26211b 
- rename URLs
- rename `ITraktSyncRecommendationsPost` => `ITraktSyncFavoritesPost`
- rename `ITraktSyncRecommendationsRemovePost` => `ITraktSyncFavoritesRemovePost`
- rename `ITraktSyncRecommendationsPostResponse` => `ITraktSyncFavoritesPostResponse`
- rename `ITraktSyncRecommendationsRemovePostResponse` => `ITraktSyncFavoritesRemovePostResponse`
- rename `ITraktSyncRecommendationsPostBuilder` => `ITraktSyncFavoritesPostBuilder`
- rename `ITraktSyncRecommendationsRemovePostBuilder` => `ITraktSyncFavoritesRemovePostBuilder`
- remove unnecessary tests
@henrikfroehling henrikfroehling linked a pull request Jul 22, 2023 that will close this issue
PR: #556 - Rename sync/recommendations requests to sync/favorites #583
Merged
henrikfroehling added a commit that referenced this issue Jul 22, 2023
@henrikfroehling
Merge pull request #583 from henrikfroehling/issue/release-1.4.0/GH-556
1f8d158 
Resolves GH-556
@github-project-automation github-project-automation bot moved this from Open to Closed in Trakt.NET Jul 22, 2023
@henrikfroehling henrikfroehling moved this from Closed to Done in Trakt.NET Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrikfroehling henrikfroehling

Labels
Improvement Library Module Sync Target-Branch: release-1.4.0 Trakt API v1.4.0
Projects
Trakt.NET
Status: Done
Milestone
Version 1.4.0
Development

Successfully merging a pull request may close this issue.

PR: #556 - Rename sync/recommendations requests to sync/favorites henrikfroehling/Trakt.NET
1 participant
@henrikfroehling