Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: #606 - Add missing properties in ITraktSyncLastActivities #607

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

henrikfroehling
Copy link
Owner

No description provided.

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (0d902db) 77.62% compared to head (1e08383) 77.58%.

Files Patch % Lines
.../Writer/SyncNotesLastActivitiesObjectJsonWriter.cs 0.00% 7 Missing ⚠️
.../Json/Writer/SyncLastActivitiesObjectJsonWriter.cs 0.00% 4 Missing and 1 partial ⚠️
.../Reader/SyncNotesLastActivitiesObjectJsonReader.cs 69.23% 2 Missing and 2 partials ⚠️
.../Factories/SyncNotesLastActivitiesJsonIOFactory.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.4.0     #607      +/-   ##
=================================================
- Coverage          77.62%   77.58%   -0.05%     
=================================================
  Files               1555     1559       +4     
  Lines              25920    25953      +33     
  Branches            5653     5659       +6     
=================================================
+ Hits               20121    20136      +15     
- Misses              5428     5443      +15     
- Partials             371      374       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henrikfroehling henrikfroehling merged commit 4e65ce5 into release-1.4.0 Dec 1, 2023
@henrikfroehling henrikfroehling deleted the issue/release-1.4.0/GH-606 branch December 1, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing properties in ITraktSyncLastActivities
1 participant