binfmt/copyactions: fix comments, make the actions life cycle more clear

Signed-off-by: buxiasen <[email protected]>
henryrov · Feb 23, 2025 · e072771 · e072771
1 parent 0e5cb89
commit e072771
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/binfmt/binfmt.h b/binfmt/binfmt.h
@@ -177,7 +177,8 @@ void binfmt_freeargv(FAR char * const *argv);
  *   do not have any real option other than to copy the callers action list.
  *
  * Input Parameters:
- *   copy     - Pointer of file actions
+ *   copy     - Pointer of the copied output file actions
+ *   actions  - Pointer of file actions to be copy
  *
  * Returned Value:
  *   A non-zero copy is returned on success.

diff --git a/binfmt/binfmt_copyactions.c b/binfmt/binfmt_copyactions.c
@@ -52,7 +52,8 @@
  *   do not have any real option other than to copy the callers action list.
  *
  * Input Parameters:
- *   copy     - Pointer of file actions
+ *   copy     - Pointer of the copied output file actions
+ *   actions  - Pointer of file actions to be copy
  *
  * Returned Value:
  *   A non-zero copy is returned on success.
@@ -108,6 +109,11 @@ int binfmt_copyactions(FAR const posix_spawn_file_actions_t **copy,
       return -ENOMEM;
     }
 
+  /* We need to copy and re-organize the flink chain,  be care not modify
+   * the actions it self,  the prev have to point to the last time foreach
+   * item.
+   */
+
   for (entry = (FAR struct spawn_general_file_action_s *)actions,
        prev = NULL; entry != NULL; entry = entry->flink)
     {