Update Go to version 1,14

heppu · Mar 11, 2020 · feebdff · feebdff
1 parent ae70663
commit feebdff
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,6 +1,6 @@
 language: go
 
-go: 1.12
+go: 1.14
 
 branches:
   only:
@@ -9,7 +9,7 @@ branches:
 
 before_install:
   - env GO111MODULE=off go get github.com/mattn/goveralls
-  - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.17.1
+  - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.23.8
   - env GO111MODULE=on go mod download
 
 script:

diff --git a/Makefile b/Makefile
@@ -1,5 +1,3 @@
-export GO111MODULE = on
-
 BIN_FILE = target/bin/go-review
 COVERAGE_FILE = target/test/coverage.txt
 
@@ -15,7 +13,7 @@ test:
 
 .PHONY: lint
 lint:
-	golangci-lint run --tests=false --enable-all --disable=lll,gochecknoglobals ./...
+	golangci-lint run --tests=false --enable-all --disable=lll,gochecknoglobals,wsl,gomnd ./...
 
 .PHONY: goveralls
 goveralls: test

diff --git a/cmd/go-review/main.go b/cmd/go-review/main.go
@@ -67,7 +67,6 @@ func main() {
 		fmt.Println(err)
 		os.Exit(1)
 	}
-
 }
 
 func parseEnv(name string, must bool) string {
-Original file line number
+Diff line change
@@ Expand Up / @@ -67,7 +67,6 @@ func main() { @@
     		fmt.Println(err)
     		os.Exit(1)
     	}
     }
     func parseEnv(name string, must bool) string {
@@ Expand Down @@