Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[litmus,test] Fix a few glitches #1087

Merged
merged 2 commits into from
Dec 7, 2024
Merged

[litmus,test] Fix a few glitches #1087

merged 2 commits into from
Dec 7, 2024

Conversation

maranget
Copy link
Member

@maranget maranget commented Dec 3, 2024

Restore make litmus-aarch64-test functionality.

@maranget
Copy link
Member Author

maranget commented Dec 3, 2024

Hi @relokin, @murzinv. We should probably install some action to run make litmus-x64_64-test and make litmus-aarch64-test periodically, as we do for building herd-www.

@relokin
Copy link
Member

relokin commented Dec 3, 2024

Hi @relokin, @murzinv. We should probably install some action to run make litmus-x64_64-test and make litmus-aarch64-test periodically, as we do for building herd-www.

I agree @maranget! I think Github has both Arm and x86 runners so we would be able to both compile and run tests. It might also be helpful if we could (manually) run the regression on a PR that makes changes to litmus/ or lib/

@maranget
Copy link
Member Author

maranget commented Dec 3, 2024

We could at least compile the tests....

@maranget
Copy link
Member Author

maranget commented Dec 3, 2024

... and we thus need either to install the right cross-compiler and tools, whatever the platform, or be able to select the appropriate platform to use the local compiler.

@maranget
Copy link
Member Author

maranget commented Dec 3, 2024

I had a try for a periodic action that tests litmus, x86_64 only. See PR #1090.

@maranget
Copy link
Member Author

maranget commented Dec 6, 2024

Hi @relokin, @murzinv, would your agree that I merge this PR? It is quite simple.

@murzinv
Copy link
Contributor

murzinv commented Dec 6, 2024

No objection from my side

@relokin
Copy link
Member

relokin commented Dec 6, 2024

No objection from my side either. The only question I had is whether it’s necessary to require v8.4, for many users that would mean that the binaries wouldn’t run.

@maranget maranget force-pushed the fix-litmus-test-aarch64 branch from 57c86f6 to 9835c8e Compare December 6, 2024 19:58
@maranget
Copy link
Member Author

maranget commented Dec 6, 2024

Good point @relokin. I attempted a less demanding requirement: armv8.1 with FEAT_LRCPC. Apparently it works.

@maranget maranget force-pushed the fix-litmus-test-aarch64 branch from 9835c8e to 27ebeee Compare December 6, 2024 20:01
  + Fix reference to non-existing directories in some of catalogue index files.
  + Change Makefile variable for `make litmus-aarch64-test RUN_TESTS=true` to function.

Additionaly some catalogue tests use the `LDAPR` instruction.
As a consequence, gcc compilation flag -march=armv8.1-a+rcpc.
  1. Less iterations for aarch64 kvm tests
  2. Some tests are not terminating,
     do not run their batch.
@maranget maranget merged commit 0a106d8 into master Dec 7, 2024
3 checks passed
@maranget maranget deleted the fix-litmus-test-aarch64 branch December 7, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants