[asl] limit constraint size after explosion #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienRenaud
force-pushed
the
asl-fix-stack-overflow-binop
branch
5 times, most recently
from
8d9b5fb to
5bb7def
Compare
hrutvik
reviewed
Jan 22, 2025
Roman-Manevich
approved these changes
Jan 22, 2025
HadrienRenaud
force-pushed
the
asl-fix-stack-overflow-binop
branch
2 times, most recently
from
240fe92 to
a5cf0a7
Compare
HadrienRenaud
force-pushed
the
asl-fix-stack-overflow-binop
branch
from
a5cf0a7 to
9191fe1
Compare
HadrienRenaud
force-pushed
the
asl-fix-stack-overflow-binop
branch
from
9191fe1 to
7320b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the explosion of constraint sets (e.g. turn
{1..4}into{1, 2, 3, 4}before an operation such as*) was only done on a interval per interval basis, without taking into account the other side of the operations.We now perform a very simple estimate of how big the constraint set after the operation will be, based on this decide if we want to explode intervals in a constraint set or not.
Currently the limit is fixed at
2^17.