Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asl] Fix unsound controlflow analysis for try .. catch #1140

Merged

Conversation

HadrienRenaud
Copy link
Collaborator

@HadrienRenaud HadrienRenaud commented Jan 22, 2025

  • Code implementation
  • Tests showing before/after difference
  • Documentation -> defered to another PR by @Roman-Manevich

Copy link
Collaborator

@Roman-Manevich Roman-Manevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@HadrienRenaud HadrienRenaud force-pushed the asl-controlflow-unsound-fix branch from 17cfc05 to a938b51 Compare January 22, 2025 16:48
@HadrienRenaud HadrienRenaud force-pushed the asl-controlflow-unsound-fix branch from a938b51 to 8b8b146 Compare January 22, 2025 20:08
@HadrienRenaud HadrienRenaud marked this pull request as ready for review January 22, 2025 22:14
@HadrienRenaud HadrienRenaud merged commit 581c9bc into herd:master Jan 22, 2025
2 checks passed
@HadrienRenaud HadrienRenaud deleted the asl-controlflow-unsound-fix branch January 22, 2025 22:14
Roman-Manevich added a commit that referenced this pull request Jan 24, 2025
[asl][reference] Synchronize reference for #1140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants