Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the ad-hoc installation process by upgrading to dune 3.5 #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kit-ty-kate
Copy link

Once ocaml/dune#6133 is fixed this should work and does simplify the installation process

@maranget
Copy link
Member

maranget commented Sep 16, 2022

Once ocaml/dune#6133 is fixed this should work and does simplify the installation process

Thanks @kit-ty-kate, the issue looks as if it is still open, So no emergency to merge this PR? I'd rather avoid mandatory dune upgrade. Would your change be compatible with "reasonably recent" versions of dune?

@kit-ty-kate
Copy link
Author

So no emergency to merge this PR?

No, don't worry.

I'd rather avoid mandatory dune upgrade. Would your change be compatible with "reasonably recent" versions of dune?

Sadly no. The new (install (dirs ...)) feature necessary to make it work is only present in dune master / the next planned release.

@maranget
Copy link
Member

Thanks @kit-ty-kate. No need to hurry, then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants