[herd] Restore the cos-opt.cat file as it was.
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some models (namely the LKMM model) use cos-opt.cat directly. Those models cannot include the new co's generator that _requires_ relation `pco` to be computed, which in turn needs option `-optace true`. Notice that the optmised co's computation introduced by PR #430 is still working, with `cos-opt.cat` now being named `cos-ok-opt.cat`.
maranget
added a commit
that referenced
this pull request
Oct 17, 2023
[herd] Restore the `cos-opt.cat` file as it was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some models (namely the LKMM model) use cos-opt.cat directly. Those models cannot include the new co's generator that requires relation
pcoto be computed, which in turn needs option-optace true.Notice that the optimised co's computation introduced by PR #430 is still working, with
cos-opt.catnow being namedcos-ok-opt.cat.