Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[herd,asl] Fix inversion of ADD and ADDS semantics. #652

Merged
merged 1 commit into from
Sep 11, 2023
Merged

[herd,asl] Fix inversion of ADD and ADDS semantics. #652

merged 1 commit into from
Sep 11, 2023

Conversation

maranget
Copy link
Member

@maranget maranget commented Sep 8, 2023

There are still difficulties. with NZCV flags. The following test. crashes:

AArch64 T
{
int x=1;
0:X8=x;
}

 P0           ;
MOV W0,#1     ;
LDR W1,[X8]   ;
ADDS W2,W1,W0 ;
ADDS W2,W1,W0 ;
locations [0:X2;]

@maranget maranget merged commit a0cf14a into master Sep 11, 2023
@maranget maranget deleted the asl-fix-add branch September 11, 2023 12:52
maranget added a commit that referenced this pull request Oct 17, 2023
@maranget
Merge pull request #652 from herd/asl-fix-add
a3ed798 
[herd,asl] Fix inversion of ADD and ADDS semantics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maranget