Dart: fix compilation error caused by missing includes for async functions #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FfiCppIncludeResolver class was not resolving includes correctly, because certain includes were missing. Sadly, the problem was not visible because of the order of includes in unity file. This commit changes namespace in 'Async.lime' to force the early inclusion of files related to async tests in unity file. This way the compilation error is visible. In next commits it will be resolved Signed-off-by: Patryk Wrobel <[email protected]>
Certain includes were missing. It was confirmed via functional tests. This change adjusts the class, which resolves includes for FFI code to fix the problem. Smoke tests have been also adjusted. Signed-off-by: Patryk Wrobel <[email protected]>
Signed-off-by: Patryk Wrobel <[email protected]>
|
Note to reviewers: the functional tests failed for the reproducer (visible in history). |
Hsilgos
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FfiCppIncludeResolver class was not resolving includes correctly,
because certain includes were missing. Sadly, the problem was not
visible because of the order of includes in unity file.
This change: