Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove profiles from non root packages #3

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Remove profiles from non root packages #3

merged 1 commit into from
Mar 25, 2024

Conversation

mkroening
Copy link
Member

Fixes:

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   rftrace/examples/hermitrust/Cargo.toml
workspace: rftrace/Cargo.toml

@tlambertz
Copy link
Collaborator

The profiles are there intentionally (even if not well documented currently), so that if you copy the example outside of the workspace it still works in debug mode.

default:
	# we need to override the opt level for the dev profile, since we are in a workspace with other settings!
	# not needed if this folder stands on its own, since the profiles in the cargo.toml take effect
	# BUT: we build in release anyway so trace is smaller.
CARGO_PROFILE_DEV_OPT_LEVEL=1 cargo build ....

@mkroening
Copy link
Member Author

All right. 👍

@mkroening mkroening closed this Jul 15, 2021
@mkroening
Copy link
Member Author

Reopening, since this is not required on Hermit since November 2021: hermit-os/hermit-rs@f055471

@mkroening mkroening reopened this Dec 4, 2023
Fixes:
```
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   rftrace/examples/hermitrust/Cargo.toml
workspace: rftrace/Cargo.toml
```
@mkroening
Copy link
Member Author

Rebased on latest master.

@mkroening mkroening merged commit 0f1194a into hermit-os:master Mar 25, 2024
2 checks passed
@mkroening mkroening deleted the profile branch March 25, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants