vm.rs: Replace hardcoded arch::RAM_START in BootInfo #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an idea to initialize the mmap using different guest_address parameters. Despite how most of the code is already "future-proofed", with a clear intention of heading towards that direction and `vm.rs` using `self.mem.guest_address` everywhere (despite that value currently being equal to zero), this change modifies a small exception to that rule.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=======================================
Coverage 68.06% 68.06%
=======================================
Files 20 20
Lines 2311 2311
=======================================
Hits 1573 1573
Misses 738 738 ☔ View full report in Codecov by Sentry. |
jounathaen
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an idea to initialize the mmap using different guest_address parameters.
Despite how most of the code is already "future-proofed", with a clear intention of heading towards that direction and
vm.rsusingself.mem.guest_addresseverywhere (despite that value currently being equal to zero), this change modifies a small exception to that rule.