Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sandbox): only create tempfiles with O_CREAT flag #866

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Jan 18, 2025

No description provided.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (5ca9137) to head (e3d527b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hypercall.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   71.69%   71.64%   -0.05%     
==========================================
  Files          23       23              
  Lines        3077     3079       +2     
==========================================
  Hits         2206     2206              
- Misses        871      873       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jounathaen jounathaen added this pull request to the merge queue Jan 20, 2025
@jounathaen
Copy link
Member

LGTM! Thanks

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@jounathaen jounathaen enabled auto-merge January 20, 2025 10:48
@jounathaen jounathaen disabled auto-merge January 20, 2025 11:14
Plus, some additional debug! messages that I made for showcasing this
file map feature, but could be helpful for extensions as well.
@n0toose n0toose force-pushed the open-create-flag-fix branch from bded431 to e3d527b Compare January 20, 2025 12:46
@jounathaen jounathaen added this pull request to the merge queue Jan 20, 2025
Merged via the queue into hermit-os:main with commit ec96045 Jan 20, 2025
10 checks passed
@jounathaen jounathaen deleted the open-create-flag-fix branch January 20, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants