Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code generator #129

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix code generator #129

merged 1 commit into from
Nov 15, 2022

Conversation

sesposito
Copy link
Member

@sesposito sesposito commented Nov 10, 2022

Code generator was failing due to a change in how the swagger put params are defined:
grpc-ecosystem/grpc-gateway#201
Fix a few failing tests.

@sesposito sesposito requested a review from lugehorsam November 10, 2022 14:01
@sesposito sesposito force-pushed the spe-codegen-fix branch 3 times, most recently from 7b19583 to 16c2bca Compare November 10, 2022 14:13
@lugehorsam
Copy link
Contributor

What Nakama version are you running the tests against? Latest?

Copy link
Contributor

@lugehorsam lugehorsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few q's

@sesposito
Copy link
Member Author

The tests were run against master

Code generator was failing due to a change in how the swagger put
params are defined.
grpc-ecosystem/grpc-gateway#201
Fix a few failing tests.
@sesposito sesposito merged commit 9dc00af into master Nov 15, 2022
@sesposito sesposito deleted the spe-codegen-fix branch November 15, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants