Update npm registry keys for Corepack #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for Node versions that bundle a version of Corepack that is affected by recent changes to npm's public signing keys.
edmorley
approved these changes
Feb 3, 2025
colincasey
added a commit
that referenced
this pull request
Feb 3, 2025
* main: Update npm registry keys for Corepack (#1010)
heroku-linguist bot
added a commit
that referenced
this pull request
Feb 3, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.5`. - Updated `heroku/nodejs-engine` to `3.4.5`. - Updated `heroku/nodejs-npm-engine` to `3.4.5`. - Updated `heroku/nodejs-npm-install` to `3.4.5`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.5`. - Updated `heroku/nodejs-pnpm-install` to `3.4.5`. - Updated `heroku/nodejs-yarn` to `3.4.5`. ## heroku/nodejs-corepack ### Changed - Updated npm keys for Corepack versions `0.27`, `0.28`, `0.29`, `0.30`. ([#1010](#1010)) ## heroku/nodejs-engine ### Added - 23.7.0 (linux-amd64, linux-arm64) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.5`. - Updated `heroku/nodejs-function-invoker` to `3.4.5`. - Updated `heroku/nodejs-npm` to `3.4.5`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install - No changes. ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes.
Merged
heroku-linguist bot
added a commit
that referenced
this pull request
Feb 4, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.5`. - Updated `heroku/nodejs-engine` to `3.4.5`. - Updated `heroku/nodejs-npm-engine` to `3.4.5`. - Updated `heroku/nodejs-npm-install` to `3.4.5`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.5`. - Updated `heroku/nodejs-pnpm-install` to `3.4.5`. - Updated `heroku/nodejs-yarn` to `3.4.5`. ## heroku/nodejs-corepack ### Changed - Updated npm keys for Corepack versions `0.27`, `0.28`, `0.29`, `0.30`. ([#1010](#1010)) ## heroku/nodejs-engine ### Added - 23.7.0 (linux-amd64, linux-arm64) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.5`. - Updated `heroku/nodejs-function-invoker` to `3.4.5`. - Updated `heroku/nodejs-npm` to `3.4.5`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install - No changes. ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Feb 4, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.5`. - Updated `heroku/nodejs-engine` to `3.4.5`. - Updated `heroku/nodejs-npm-engine` to `3.4.5`. - Updated `heroku/nodejs-npm-install` to `3.4.5`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.5`. - Updated `heroku/nodejs-pnpm-install` to `3.4.5`. - Updated `heroku/nodejs-yarn` to `3.4.5`. ## heroku/nodejs-corepack ### Changed - Updated npm keys for Corepack versions `0.27`, `0.28`, `0.29`, `0.30`. ([#1010](heroku/buildpacks-nodejs#1010)) ## heroku/nodejs-engine ### Added - 23.7.0 (linux-amd64, linux-arm64) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.5`. - Updated `heroku/nodejs-function-invoker` to `3.4.5`. - Updated `heroku/nodejs-npm` to `3.4.5`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install - No changes. ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes.
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Feb 4, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.5`. - Updated `heroku/nodejs-engine` to `3.4.5`. - Updated `heroku/nodejs-npm-engine` to `3.4.5`. - Updated `heroku/nodejs-npm-install` to `3.4.5`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.5`. - Updated `heroku/nodejs-pnpm-install` to `3.4.5`. - Updated `heroku/nodejs-yarn` to `3.4.5`. ## heroku/nodejs-corepack ### Changed - Updated npm keys for Corepack versions `0.27`, `0.28`, `0.29`, `0.30`. ([#1010](heroku/buildpacks-nodejs#1010)) ## heroku/nodejs-engine ### Added - 23.7.0 (linux-amd64, linux-arm64) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.5`. - Updated `heroku/nodejs-function-invoker` to `3.4.5`. - Updated `heroku/nodejs-npm` to `3.4.5`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install - No changes. ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
pranavrajs
pushed a commit
to chatwoot/chatwoot
that referenced
this pull request
Feb 5, 2025
So, a while back Circle CI builds and Heroku builds started to fail. From all the threads I read, it seems like the [npm registry rotated it's signing keys](pnpm/pnpm#9014 (comment)) New pnpm versions were signed with the new key. Corepack, however, bundles a static set of trusted keys (from Node’s release), so it continued verifying signatures only against the old key. When it encountered packages signed with the new key, Corepack’s integrity check failed with “Cannot find matching keyid” errors.This mismatch caused Corepack’s integrity check to fail with “Cannot find matching keyid” errors. Workarounds include the following 1. Updating Corepack (to 0.31.0), they [upgraded their package](https://github.com/nodejs/corepack/releases/tag/v0.31.0) to include the new integrity check keys. But we seldom control what's going on with the CI, also, updating this across our scripts is going to be a painful task. Besides Heroku has [made some fixes](heroku/buildpacks-nodejs#1010) around this 2. Disabling integrity checks 🔥 #YOLO 3. Pinning `pnpm` to older versions, or pinning it to a newer version with the checksum in place. Doing the third one here, running `corepack use [email protected]` fixes this, [ref](pnpm/pnpm#9014 (comment)) We can get rid of this over time as CDN caches used by build systems are refreshed. But the change in this PR is not disruptive in anyway, only rigidly secure. Fixes: #10832 --- Here are the threads to follow - pnpm/pnpm#9014 - pnpm/pnpm#9029 - nodejs/corepack#612 - nodejs/corepack#616 - heroku/buildpacks-nodejs#1010 --------- Co-authored-by: Vishnu Narayanan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for Node versions that bundle a version of Corepack that is affected by recent changes to npm's public signing keys.