chore: update telemetry/index tests to use fixtures

heroku · Oct 17, 2024 · ca0eef5 · ca0eef5
1 parent 2005912
commit ca0eef5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 48 deletions.
diff --git a/packages/cli/test/fixtures/telemetry/fixtures.ts b/packages/cli/test/fixtures/telemetry/fixtures.ts
@@ -1,4 +1,6 @@
-export const spaceTelemetryDrain1 = {
+import {TelemetryDrain} from '../../../src/lib/types/telemetry'
+
+export const spaceTelemetryDrain1: TelemetryDrain = {
   id: '44444321-5717-4562-b3fc-2c963f66afa6',
   owner: {id: '12345678-5717-4562-b3fc-2c963f66afa6', type: 'space', name: 'myspace'},
   capabilities: ['traces', 'metrics', 'logs'],
@@ -12,7 +14,7 @@ export const spaceTelemetryDrain1 = {
   },
 }
 
-export const appTelemetryDrain1 = {
+export const appTelemetryDrain1: TelemetryDrain = {
   id: '3fa85f64-5717-4562-b3fc-2c963f66afa6',
   owner: {id: '87654321-5717-4562-b3fc-2c963f66afa6', type: 'app', name: 'myapp'},
   capabilities: ['traces', 'metrics'],
@@ -26,7 +28,7 @@ export const appTelemetryDrain1 = {
   },
 }
 
-export const appTelemetryDrain2 = {
+export const appTelemetryDrain2: TelemetryDrain = {
   id: '55555f64-5717-4562-b3fc-2c963f66afa6',
   owner: {id: '87654321-5717-4562-b3fc-2c963f66afa6', type: 'app', name: 'myapp'},
   capabilities: ['logs'],

diff --git a/packages/cli/test/unit/commands/telemetry/index.unit.test.ts b/packages/cli/test/unit/commands/telemetry/index.unit.test.ts
@@ -5,57 +5,19 @@ import * as nock from 'nock'
 import expectOutput from '../../../helpers/utils/expectOutput'
 import heredoc from 'tsheredoc'
 import {TelemetryDrains} from '../../../../src/lib/types/telemetry'
+import {spaceTelemetryDrain1, appTelemetryDrain1, appTelemetryDrain2} from '../../../fixtures/telemetry/fixtures'
 
 describe('telemetry:index', function () {
-  const appId = '87654321-5717-4562-b3fc-2c963f66afa6'
-  const spaceId = '12345678-5717-4562-b3fc-2c963f66afa6'
+  let appId: string
+  let spaceId: string
   let appTelemetryDrains: TelemetryDrains
   let spaceTelemetryDrains: TelemetryDrains
 
   beforeEach(function () {
-    spaceTelemetryDrains = [
-      {
-        id: '44444321-5717-4562-b3fc-2c963f66afa6',
-        owner: {id: spaceId, type: 'space', name: 'myspace'},
-        capabilities: ['traces', 'metrics', 'logs'],
-        exporter: {
-          type: 'otlphttp',
-          endpoint: 'https://api.honeycomb.io/',
-          headers: {
-            'x-honeycomb-team': 'your-api-key',
-            'x-honeycomb-dataset': 'your-dataset',
-          },
-        },
-      },
-    ]
-    appTelemetryDrains = [
-      {
-        id: '3fa85f64-5717-4562-b3fc-2c963f66afa6',
-        owner: {id: appId, type: 'app', name: 'myapp'},
-        capabilities: ['traces', 'metrics'],
-        exporter: {
-          type: 'otlphttp',
-          endpoint: 'https://api.honeycomb.io/',
-          headers: {
-            'x-honeycomb-team': 'your-api-key',
-            'x-honeycomb-dataset': 'your-dataset',
-          },
-        },
-      },
-      {
-        id: '55555f64-5717-4562-b3fc-2c963f66afa6',
-        owner: {id: appId, type: 'app', name: 'myapp'},
-        capabilities: ['logs'],
-        exporter: {
-          type: 'otlphttp',
-          endpoint: 'https://api.papertrail.com/',
-          headers: {
-            'x-papertrail-team': 'your-api-key',
-            'x-papertrail-dataset': 'your-dataset',
-          },
-        },
-      },
-    ]
+    appId = appTelemetryDrain1.owner.id
+    spaceId = spaceTelemetryDrain1.owner.id
+    spaceTelemetryDrains = [spaceTelemetryDrain1]
+    appTelemetryDrains = [appTelemetryDrain1, appTelemetryDrain2]
   })
 
   afterEach(function () {