fix(addons-v5): Use os.tmpdir() rather than /tmp for cross-platform support - fixes #1506 #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetanley
suggested changes
May 15, 2020
|
|
||
| function open (url) { | ||
| cli.log(`Opening ${cli.color.cyan(url)}...`) | ||
| return cli.open(url) | ||
| } | ||
|
|
||
| const ssoPath = '/tmp/heroku-sso.html' | ||
| const ssoPath = os.tmpdir() + '/heroku-sso.html' |
There was a problem hiding this comment.
can you add an import for path = require('path') at the top of the page and use path.join(os.tmpdir(), 'heroku-sso.html') instead? this will help keep the path separators (\ on windows, / on mac/linux) normalized between platforms.
There was a problem hiding this comment.
Nice! Made this change, thanks!
fivetanley
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
addons:openwith sudo on windows showsENOENT: no such file or directory, open 'C:\tmp\heroku-sso.html'./tmpis not available by default in windows. This change uses os.tmpdir() rather than/tmp.