-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(domains): update custom domains functionality #2920
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Workflow looks good; we talked about fixing filtering --filter "blue.com" and having that list the results without the error message (assuming its under 100) |
Need to update types and update logic for when this condition will be true. Currently defaulted to true verify size of filtered domains
8bcc436
to
6be40a6
Compare
zwhitfield3
commented
Jul 18, 2024
zwhitfield3
commented
Jul 18, 2024
zwhitfield3
commented
Jul 18, 2024
3afe442
to
8db83e2
Compare
8db83e2
to
f37f31f
Compare
justinwilaby
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work Item
Work Item
Work Item
This PR updates and introduces a few new changes for custom domains and the Heroku CLI in general.
keyValueParser
utility function to parse any@oclif/core
flags that may contain spaces such as./bin/run domains -a testing-deploy --filter 'Domain Name=ztestdomain7'
Testing
NOTE: In order to test these updates, you'll need an app with over 1,000 domains. If you don't have one, please ping me to add you to the test app,
testing-deploy
.yarn
it up./bin/run domains -a testing-deploy
no
as the default optiony
. Confirm that all domains are shown.csv
file by running the example command via./bin/run domains -a testing-deploy --csv > test-domains-file.csv
csv
file./bin/run domains -a testing-deploy --filter 'Domain Name=ztestdomain7'
./bin/run domains -a testing-deploy --filter 'Domain Name=sara'