Add telemetry remove command #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
force-pushed
the
eb/add-telemetry-remove-command
branch
from
9c6b4d5 to
635221f
Compare
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
approved these changes
Oct 17, 2024
Comment on lines
33
to
38
| ux.action.start(`Removing all telemetry drains from app ${app}`) | ||
| const {body: telemetryDrains} = await this.heroku.get<TelemetryDrain[]>(`/apps/${app}/telemetry-drains`, { | ||
| headers: { | ||
| Accept: 'application/vnd.heroku+json; version=3.fir', | ||
| }, | ||
| }) |
There was a problem hiding this comment.
Should the fact that this action could remove all telemetry drains from an app or space be mentioned in the description?
There was a problem hiding this comment.
i'll check with sandy about this. it is mentioned in the flag's description, but maybe it merits an adjustment to the command's overall description?
eablack
force-pushed
the
eb/add-telemetry-remove-command
branch
from
635221f to
6548c3e
Compare
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUS WI
Description
Adds
telemetry:removecommand. Will accept an ID for a specific telemetry drain, or--appto remove all drains associated with an app or--spaceto remove all drains associated with a space.