Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): add output for waiting logs #3066

Merged
merged 5 commits into from
Nov 4, 2024
Merged

chore(cli): add output for waiting logs #3066

merged 5 commits into from
Nov 4, 2024

Conversation

zwhitfield3
Copy link
Contributor

@zwhitfield3 zwhitfield3 commented Oct 30, 2024 •
edited
Loading

Description

Work Item

This PR adds output to the heroku logs command to let the user know it is waiting for logs to be produced for Fir apps.

Testing

  1. Pull down branch & yarn it up
  2. Ensure initial log output ('Waiting for logs...') is visible when running logs via ./bin/run logs -a <fir-app>
  3. Open your fir app and refresh the url. Ensure logs populate after initial log output

@zwhitfield3 zwhitfield3 marked this pull request as ready for review October 31, 2024 00:11
@zwhitfield3 zwhitfield3 requested a review from a team as a code owner October 31, 2024 00:11
sbosio
sbosio requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some recommendations. Take a look at those and let me know if they make sense.

packages/cli/src/lib/run/log-displayer.ts Outdated Show resolved Hide resolved
packages/cli/test/unit/lib/run/log-displayer.unit.test.ts Outdated Show resolved Hide resolved
packages/cli/test/unit/lib/run/log-displayer.unit.test.ts Outdated Show resolved Hide resolved
sbosio
sbosio approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Good work!

@zwhitfield3 zwhitfield3 merged commit cbe1790 into prerelease/10.0.0-alpha Nov 4, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the zw/buffer-log-output branch November 4, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eablack eablack eablack left review comments

@SandyPantsLai SandyPantsLai SandyPantsLai left review comments

@sbosio sbosio sbosio approved these changes

@justinwilaby justinwilaby justinwilaby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zwhitfield3 @eablack @sbosio @justinwilaby @SandyPantsLai