fix: show only generation name in spaces:info output #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
force-pushed
the
k80/fix-spaces-info-generation
branch
from
ef837f0 to
3db8fff
Compare
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item
In the output of the
spaces:infoandspaces:waitcommands, the "generation" field was showing the UUID and the name of the generation, instead of just the name. This was due to a change in the API. This PR updates the output to only show the name.Testing
yarnandyarn build./bin/run spaces:info -s FIR-SPACE-NAME. Verify that the output shows only the name of the generation and not an object with the UUID../bin/run spaces:info -s CEDAR-SPACE-NAME. Verify that the output shows only the name of the generation and not an object with the UUID./bin/run spaces:wait -s FIR-SPACE-NAME. Verify that the output shows only the name of the generation and not an object with the UUID.