Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: run:inside hangs (doesn't error) when no/invalid SSH key #3130

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

justinwilaby
Copy link
Contributor

Fixes the hanging process when no SSH keys or invalid SSH keys are used to run a process inside a dyno

testing

  1. Move all keys from the default location ~/.ssh to another directory
  2. create another key ssh-keygen
  3. Don't upload it to heroku
  4. run inside `./bin run run:inside -a YOUR_APP YOUR_DYNO "node -v"
  5. OBSERVE: The Permission denied (publickey) error is thrown and the process exits with exitcode 1

@justinwilaby justinwilaby requested a review from a team as a code owner December 6, 2024 19:35
@justinwilaby justinwilaby changed the base branch from main to prerelease/10.0.0-alpha December 6, 2024 19:36
Copy link
Contributor

@angeldcampbell angeldcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵

Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind a test or two around this, but the implementation looks good. Thank you.

@justinwilaby justinwilaby merged commit b44fcf8 into prerelease/10.0.0-alpha Dec 6, 2024
8 checks passed
@justinwilaby justinwilaby deleted the jw/fix/run-inside-hangs branch December 6, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants