Source repos for editable Pipenv VCS installs are not cached between builds #1527
Assignees
Labels
Comments
edmorley
added a commit
that referenced
this issue
Jan 6, 2024
When installing a VCS dependency in editable mode, the source repository has to be git cloned somewhere, and that location referenced via a `.pth` file added to `site-packages`. Previously, when using Pipenv the default source repository location was used, which is a `src/` directory inside the current working directory. ie: `/app/src/`. However, this directory is not preserved/cached across builds, meaning that on the next Pipenv install the repository has to be cloned from scratch. Now, the source repository location when using Pipenv has been overridden to `/app/.heroku/src/`, which is cached, and matches the location used for Pip projects. This is configured via Pipenv's `--extra-pip-args` feature: https://pipenv.pypa.io/en/latest/advanced.html#supplying-additional-arguments-to-pip Lastly, the standard Pip install invocation args have been tweaked to consistently use quotes and the absolute path. Fixes #1527. GUS-W-14764812.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when using Pipenv, the source repository for editable VCS installs defaults to being cloned into the app directory, at
/app/src/<repo>.This directory isn't cached, meaning for repeat builds the repo has to be cloned again from scratch.
In comparison, when using Pip instead of Pipenv, we force the source directory to be created at
/app/.heroku/src/<repo>instead, by passing--srcwhen invokingpip install.We should do the same thing for Pipenv, to speed up builds.
GUS-W-14764812.
The text was updated successfully, but these errors were encountered: