Remove duplicate copy of shunit2 #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests use `test/shunit2` so the copy under `vendor/` is redundant. I've added to the CHANGELOG since `vendor/` is added by the buildpack to `PATH` (something long term we should stop doing), increasing the chance an app was accidentally relying upon `shunit2` (albeit still unlikely). Closes @W-8145517@.
danielleadams
approved these changes
Oct 1, 2020
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
The tests use `test/shunit2` so the copy under `vendor/` is redundant. I've added to the CHANGELOG since `vendor/` is added by the buildpack to `PATH` (something long term we should stop doing), increasing the chance an app was accidentally relying upon `shunit2` (albeit still unlikely). Closes @W-8145517@.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests use
test/shunit2so the copy undervendor/is redundant.I've added to the CHANGELOG since
vendor/is added by the buildpack toPATH(something long term we should stop doing), increasing the chance an app was accidentally relying uponshunit2(albeit still unlikely).Closes W-8145517.