Vendor buildpack-stdlib instead of fetching from S3 #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since fetching from S3 has a number of disadvantages: - it's not possible to grep the repo when trying to work out what something from the stdlib is doing - shellcheck can't fully scan the code, since it similarly doesn't have the source - another compile-time HTTP request that can fail due to transient network issues and so reduce reliability - dependency on the security/release-process of an additional bucket Since the stdlib is small, doesn't often change, and is not a binary, it's a great fit for just vendoring in the repo. Closes W-8094463.
edmorley
force-pushed
the
vendor-buildpack-stdlib
branch
from
e326a84 to
63c001a
Compare
dzuelke
approved these changes
Oct 19, 2020
Malax
approved these changes
Oct 19, 2020
edmorley
added a commit
that referenced
this pull request
Oct 19, 2020
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
Since fetching buildpack-stdlib from S3 has a number of disadvantages: - it's not possible to grep the repo when trying to work out what something from the stdlib is doing - shellcheck can't fully scan the code, since it similarly doesn't have the source - another compile-time HTTP request that can fail due to transient network issues and so reduce reliability - dependency on the security/release-process of an additional bucket Since the stdlib is small, doesn't often change, and is not a binary, it's a great fit for just vendoring in the repo. The `BIN_DIR` calculation added to `bin/utils` is based on the approach mentioned here: https://www.ostricher.com/2014/10/the-right-way-to-get-the-directory-of-a-bash-script/ ...rather than copying the version in `bin/compile`, since the latter uses `$0` so doesn't work with sourced scripts (such as `bin/utils`). Closes W-8094463.
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
The changelog entries for heroku#1099 and heroku#1100 were added to the previous release section (rather than the "unreleased" section) by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fetching buildpack-stdlib from S3 has a number of disadvantages:
Since the stdlib is small, doesn't often change, and is not a binary, it's a great fit for just vendoring in the repo.
The
BIN_DIRcalculation added tobin/utilsis based on the approach mentioned here:https://www.ostricher.com/2014/10/the-right-way-to-get-the-directory-of-a-bash-script/
...rather than copying the version in
bin/compile, since the latter uses$0so doesn't work with sourced scripts (such asbin/utils).Closes W-8094463.