Remove vendored pip-grep script
#1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the last usage was removed in #1113, and pip-grep is actually broken on newer pip anyway (though helpfully silently ignores exceptions, so one wouldn't know). This is the first of the pip-pop removals, the rest will follow as the last usages are switched over. Whilst this tool was intended for internal buildpack usage only, the vendor directory is on `PATH`, so I've documented the removal in CHANGELOG just in case. Refs W-8208817.
dzuelke
approved these changes
Nov 12, 2020
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
Since the last usage was removed in heroku#1113, and pip-grep is actually broken on newer pip anyway (though helpfully silently ignores exceptions, so one wouldn't know). This is the first of the pip-pop removals, the rest will follow as the last usages are switched over. Whilst this tool was intended for internal buildpack usage only, the vendor directory is on `PATH`, so I've documented the removal in CHANGELOG just in case. Refs @W-8208817@.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last usage was removed in #1113, and pip-grep is actually broken on newer pip anyway (though helpfully silently ignores exceptions, so one wouldn't know).
This is the first of the pip-pop removals, the rest will follow as the last usages are switched over.
Whilst this tool was intended for internal buildpack usage only, the vendor directory is on
PATH, so I've documented the removal in CHANGELOG just in case.Refs W-8208817.