Clean up the Python binary build scripts #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
build-script-cleanup
branch
from
74c2bed to
bfec1b9
Compare
joshwlewis
approved these changes
Apr 12, 2022
Removes the build scripts for all CPython versions apart from the latest supported version of each major Python version, since we won't be building these for future stacks, so have no need to keep the scripts around (given they can be easily recreated in a DR scenario). The already built archives on S3 are not affected.
Since we won't be releasing it for Heroku-22, as: - It's a beta feature that never saw much usage. - We haven't released a new version for 18 months, and no one has asked for releases since then. - It's not been documented on Dev Center for some time.
So the scripts don't need to remove it in a fragile way. Also simplify the `ln` usage + make it more robust.
The `python3` script was only used for Python 3.7 builds, with the `python3-new` being used for all others (Python 3.8 to 3.10). The only changes in build output are for Python 3.7, which now: - Uses `--enable-loadable-sqlite-extensions`. - No longer bundles the `idle_test` directory. In addition to merging the scripts, the following improvements were made (none of these affect the built output itself): - The curl usage now has suitable retries/timeouts - xtrace is enabled for easier debugging - version parsing / URL generation is simplified - shellcheck fixes (shellcheck will be enabled later)
See the "OpenPGP Public Keys" section of: https://www.python.org/downloads/ Key values copied from keybase, and also checked against: https://github.com/docker-library/python/blob/1999778193a62d95de6816499419be4543f33e67/Dockerfile-linux.template#L50-L72
And backfill some more detailed entries for previous changes.
edmorley
force-pushed
the
build-script-cleanup
branch
from
2bc7c86 to
c27a366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for future more significant build script changes - which are needed to both bring our Python runtimes closer in alignment with other builds in the ecosystem, as well as improve compatibility with the in-progress Cloud Native Buildpack.
Aside from two small Python 3.7 changes, this PR does not affect the build output at all (those changes will come later in smaller, easier to review PRs).
Notable changes:
--enable-loadable-sqlite-extensionsand no longer ship with theidle_testmodule (which bring it in alignment with the configuration we use for Python 3.8-3.10).For more details, see the individual commit messages.
GUS-W-8060029.