Enable Bash's inherit_errexit
#1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Bash subshells (including command substitutions) do not inherit exit on error from the caller. This can cause surprises when functions are called from within command substitutions whose error handling is relying upon exit on error. However, as of Bash 4.4 this can be changed by enabling `inherit_errexit`. (The oldest Bash on our supported stacks is 5.0.) See: https://www.shellcheck.net/wiki/SC2311 https://www.gnu.org/software/bash/manual/html_node/The-Shopt-Builtin.html
dzuelke
approved these changes
Oct 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Bash subshells (including command substitutions) do not inherit exit on error from the caller. This can cause surprises when functions are called from within command substitutions whose error handling is relying upon exit on error. For example, this cause error handling not to work as expected in the upcoming Python version handling reimplementation.
However, as of Bash 4.4 this can be changed by enabling
inherit_errexit. (The oldest Bash on our supported stacks is 5.0.)See:
https://www.shellcheck.net/wiki/SC2311
https://www.gnu.org/software/bash/manual/html_node/The-Shopt-Builtin.html
GUS-W-16899232.