Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got version 11.8.6 throws an error with auth option. #40

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

mijoharas
Copy link
Contributor

yarn.lock in this package specifies got version 11.8.6, which throws an error when given the auth option here.

The base heroku-cli has multiple versions of got so I think this might be a module resolution issue.

Full explanation:
As recommended in the docs I'm using the arch package. ref.

This package removes the pin on node, and reinstalls the dependencies, which removes alternate versions of the got dependency. ref

on my machine.

$ cat yarn.lock | grep '/got/' | grep resolved
  resolved "https://registry.yarnpkg.com/got/-/got-11.8.6.tgz#276e827ead8772eddbcfc97170590b841823233a"

This version of got throws an error if you try and pass auth as an option to it, and triggers an error in ps:exec in the updateClientKey function here. This calls got and throws a TypeError here.

Solutions are either re-introduce the node pinning in the aur package, or update heroku-cli-exec to use username/password. Let me see about making a PR for that.

internal support ticket: https://help.heroku.com/1417095

@mijoharas mijoharas requested a review from a team as a code owner August 1, 2024 11:24
@sbosio sbosio force-pushed the fix-incorrect-usage-of-got branch from 909169b to 92754dd Compare December 27, 2024 15:46
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Got deprecated auth in favor of username and password for Basic auth.

@sbosio sbosio merged commit ed297a7 into heroku:main Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants