Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate based on latest schema #40

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Regenerate based on latest schema #40

merged 1 commit into from
Jan 3, 2019

Conversation

alindeman
Copy link
Contributor

This is the result of running script/generate.

@alindeman alindeman requested a review from talbright January 3, 2019 20:46
@talbright
Copy link
Contributor

Please create a release and use semantic versioning when you merge 🙏 🤓

@alindeman
Copy link
Contributor Author

Please create a release and use semantic versioning when you merge 🙏 🤓

I think I'd like to have a strategy that works for go mod (and, ideally, the least breaking way for existing users too) before creating a tagged release. I need some time to experiment on that front. Let's chat over in #39 on that.

@alindeman alindeman merged commit ad17585 into master Jan 3, 2019
@alindeman alindeman deleted the regenerate branch January 3, 2019 22:41
@mars
Copy link
Member

mars commented Jan 4, 2019

Before merging any module system changes, let's please make a release containing the current "pre-go mod" client.

@mars mars mentioned this pull request Jan 31, 2019
Closed
@talbright talbright mentioned this pull request Mar 29, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talbright talbright talbright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alindeman @talbright @mars